Skip to content

Commit b0866f6

Browse files
fhahnfhahn
committed
[InstCombine] Precommit umul.with.overflow sign check test.
Precommit tests for D74141.
1 parent ffd78a0 commit b0866f6

File tree

1 file changed

+197
-0
lines changed

1 file changed

+197
-0
lines changed

‎llvm/test/Transforms/InstCombine/umul-sign-check.ll

Lines changed: 197 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,197 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
2+
; RUN: opt -instcombine -S %s | FileCheck %s
3+
4+
; Check that we simplify llvm.umul.with.overflow, if the overflow check is
5+
; weakened by or (icmp ne %res, 0) %overflow. This is generated by code using
6+
; __builtin_mul_overflow with negative integer constants, e.g.
7+
8+
; bool test(unsigned long long v, unsigned long long *res) {
9+
; return __builtin_mul_overflow(v, -4775807LL, res);
10+
; }
11+
12+
declare { i64, i1 } @llvm.umul.with.overflow.i64(i64, i64) #0
13+
14+
define i1 @test1(i64 %a, i64 %b, i64* %ptr) {
15+
; CHECK-LABEL: @test1(
16+
; CHECK-NEXT: [[RES:%.*]] = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 [[A:%.*]], i64 [[B:%.*]])
17+
; CHECK-NEXT: [[OVERFLOW:%.*]] = extractvalue { i64, i1 } [[RES]], 1
18+
; CHECK-NEXT: [[MUL:%.*]] = extractvalue { i64, i1 } [[RES]], 0
19+
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i64 [[MUL]], 0
20+
; CHECK-NEXT: [[OVERFLOW_1:%.*]] = or i1 [[OVERFLOW]], [[CMP]]
21+
; CHECK-NEXT: store i64 [[MUL]], i64* [[PTR:%.*]], align 8
22+
; CHECK-NEXT: ret i1 [[OVERFLOW_1]]
23+
;
24+
25+
%res = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 %a, i64 %b)
26+
%overflow = extractvalue { i64, i1 } %res, 1
27+
%mul = extractvalue { i64, i1 } %res, 0
28+
%cmp = icmp ne i64 %mul, 0
29+
%overflow.1 = or i1 %overflow, %cmp
30+
store i64 %mul, i64* %ptr, align 8
31+
ret i1 %overflow.1
32+
}
33+
34+
define i1 @test1_or_ops_swapped(i64 %a, i64 %b, i64* %ptr) {
35+
; CHECK-LABEL: @test1_or_ops_swapped(
36+
; CHECK-NEXT: [[RES:%.*]] = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 [[A:%.*]], i64 [[B:%.*]])
37+
; CHECK-NEXT: [[OVERFLOW:%.*]] = extractvalue { i64, i1 } [[RES]], 1
38+
; CHECK-NEXT: [[MUL:%.*]] = extractvalue { i64, i1 } [[RES]], 0
39+
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i64 [[MUL]], 0
40+
; CHECK-NEXT: [[OVERFLOW_1:%.*]] = or i1 [[CMP]], [[OVERFLOW]]
41+
; CHECK-NEXT: store i64 [[MUL]], i64* [[PTR:%.*]], align 8
42+
; CHECK-NEXT: ret i1 [[OVERFLOW_1]]
43+
;
44+
45+
46+
%res = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 %a, i64 %b)
47+
%overflow = extractvalue { i64, i1 } %res, 1
48+
%mul = extractvalue { i64, i1 } %res, 0
49+
%cmp = icmp ne i64 %mul, 0
50+
%overflow.1 = or i1 %cmp, %overflow
51+
store i64 %mul, i64* %ptr, align 8
52+
ret i1 %overflow.1
53+
}
54+
55+
define i1 @test2(i64 %a, i64 %b, i64* %ptr) {
56+
; CHECK-LABEL: @test2(
57+
; CHECK-NEXT: [[RES:%.*]] = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 [[A:%.*]], i64 [[B:%.*]])
58+
; CHECK-NEXT: [[OVERFLOW:%.*]] = extractvalue { i64, i1 } [[RES]], 1
59+
; CHECK-NEXT: [[MUL:%.*]] = extractvalue { i64, i1 } [[RES]], 0
60+
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i64 [[MUL]], 0
61+
; CHECK-NEXT: [[OVERFLOW_1:%.*]] = or i1 [[OVERFLOW]], [[CMP]]
62+
; CHECK-NEXT: [[NEG:%.*]] = sub i64 0, [[MUL]]
63+
; CHECK-NEXT: store i64 [[NEG]], i64* [[PTR:%.*]], align 8
64+
; CHECK-NEXT: ret i1 [[OVERFLOW_1]]
65+
;
66+
67+
%res = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 %a, i64 %b)
68+
%overflow = extractvalue { i64, i1 } %res, 1
69+
%mul = extractvalue { i64, i1 } %res, 0
70+
%cmp = icmp ne i64 %mul, 0
71+
%overflow.1 = or i1 %overflow, %cmp
72+
%neg = sub i64 0, %mul
73+
store i64 %neg, i64* %ptr, align 8
74+
ret i1 %overflow.1
75+
}
76+
77+
declare void @use(i1)
78+
79+
define i1 @test3_multiple_overflow_users(i64 %a, i64 %b, i64* %ptr) {
80+
; CHECK-LABEL: @test3_multiple_overflow_users(
81+
; CHECK-NEXT: [[RES:%.*]] = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 [[A:%.*]], i64 [[B:%.*]])
82+
; CHECK-NEXT: [[OVERFLOW:%.*]] = extractvalue { i64, i1 } [[RES]], 1
83+
; CHECK-NEXT: [[MUL:%.*]] = extractvalue { i64, i1 } [[RES]], 0
84+
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i64 [[MUL]], 0
85+
; CHECK-NEXT: [[OVERFLOW_1:%.*]] = or i1 [[OVERFLOW]], [[CMP]]
86+
; CHECK-NEXT: call void @use(i1 [[OVERFLOW]])
87+
; CHECK-NEXT: ret i1 [[OVERFLOW_1]]
88+
;
89+
%res = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 %a, i64 %b)
90+
%overflow = extractvalue { i64, i1 } %res, 1
91+
%mul = extractvalue { i64, i1 } %res, 0
92+
%cmp = icmp ne i64 %mul, 0
93+
%overflow.1 = or i1 %overflow, %cmp
94+
call void @use(i1 %overflow)
95+
ret i1 %overflow.1
96+
}
97+
98+
; Do not simplify if %overflow and %mul have multiple uses.
99+
define i1 @test3_multiple_overflow_and_mul_users(i64 %a, i64 %b, i64* %ptr) {
100+
; CHECK-LABEL: @test3_multiple_overflow_and_mul_users(
101+
; CHECK-NEXT: [[RES:%.*]] = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 [[A:%.*]], i64 [[B:%.*]])
102+
; CHECK-NEXT: [[OVERFLOW:%.*]] = extractvalue { i64, i1 } [[RES]], 1
103+
; CHECK-NEXT: [[MUL:%.*]] = extractvalue { i64, i1 } [[RES]], 0
104+
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i64 [[MUL]], 0
105+
; CHECK-NEXT: [[OVERFLOW_1:%.*]] = or i1 [[OVERFLOW]], [[CMP]]
106+
; CHECK-NEXT: [[NEG:%.*]] = sub i64 0, [[MUL]]
107+
; CHECK-NEXT: store i64 [[NEG]], i64* [[PTR:%.*]], align 8
108+
; CHECK-NEXT: call void @use(i1 [[OVERFLOW]])
109+
; CHECK-NEXT: ret i1 [[OVERFLOW_1]]
110+
;
111+
%res = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 %a, i64 %b)
112+
%overflow = extractvalue { i64, i1 } %res, 1
113+
%mul = extractvalue { i64, i1 } %res, 0
114+
%cmp = icmp ne i64 %mul, 0
115+
%overflow.1 = or i1 %overflow, %cmp
116+
%neg = sub i64 0, %mul
117+
store i64 %neg, i64* %ptr, align 8
118+
call void @use(i1 %overflow)
119+
ret i1 %overflow.1
120+
}
121+
122+
123+
declare void @use.2({ i64, i1 })
124+
define i1 @test3_multiple_res_users(i64 %a, i64 %b, i64* %ptr) {
125+
; CHECK-LABEL: @test3_multiple_res_users(
126+
; CHECK-NEXT: [[RES:%.*]] = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 [[A:%.*]], i64 [[B:%.*]])
127+
; CHECK-NEXT: [[OVERFLOW:%.*]] = extractvalue { i64, i1 } [[RES]], 1
128+
; CHECK-NEXT: [[MUL:%.*]] = extractvalue { i64, i1 } [[RES]], 0
129+
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i64 [[MUL]], 0
130+
; CHECK-NEXT: [[OVERFLOW_1:%.*]] = or i1 [[OVERFLOW]], [[CMP]]
131+
; CHECK-NEXT: [[NEG:%.*]] = sub i64 0, [[MUL]]
132+
; CHECK-NEXT: store i64 [[NEG]], i64* [[PTR:%.*]], align 8
133+
; CHECK-NEXT: call void @use.2({ i64, i1 } [[RES]])
134+
; CHECK-NEXT: ret i1 [[OVERFLOW_1]]
135+
;
136+
%res = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 %a, i64 %b)
137+
%overflow = extractvalue { i64, i1 } %res, 1
138+
%mul = extractvalue { i64, i1 } %res, 0
139+
%cmp = icmp ne i64 %mul, 0
140+
%overflow.1 = or i1 %overflow, %cmp
141+
%neg = sub i64 0, %mul
142+
store i64 %neg, i64* %ptr, align 8
143+
call void @use.2({ i64, i1 } %res)
144+
ret i1 %overflow.1
145+
}
146+
147+
declare void @use.3(i64)
148+
149+
; Simplify if %mul has multiple uses.
150+
define i1 @test3_multiple_mul_users(i64 %a, i64 %b, i64* %ptr) {
151+
; CHECK-LABEL: @test3_multiple_mul_users(
152+
; CHECK-NEXT: [[RES:%.*]] = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 [[A:%.*]], i64 [[B:%.*]])
153+
; CHECK-NEXT: [[OVERFLOW:%.*]] = extractvalue { i64, i1 } [[RES]], 1
154+
; CHECK-NEXT: [[MUL:%.*]] = extractvalue { i64, i1 } [[RES]], 0
155+
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i64 [[MUL]], 0
156+
; CHECK-NEXT: [[OVERFLOW_1:%.*]] = or i1 [[OVERFLOW]], [[CMP]]
157+
; CHECK-NEXT: [[NEG:%.*]] = sub i64 0, [[MUL]]
158+
; CHECK-NEXT: store i64 [[NEG]], i64* [[PTR:%.*]], align 8
159+
; CHECK-NEXT: call void @use.3(i64 [[MUL]])
160+
; CHECK-NEXT: ret i1 [[OVERFLOW_1]]
161+
;
162+
163+
%res = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 %a, i64 %b)
164+
%overflow = extractvalue { i64, i1 } %res, 1
165+
%mul = extractvalue { i64, i1 } %res, 0
166+
%cmp = icmp ne i64 %mul, 0
167+
%overflow.1 = or i1 %overflow, %cmp
168+
%neg = sub i64 0, %mul
169+
store i64 %neg, i64* %ptr, align 8
170+
call void @use.3(i64 %mul)
171+
ret i1 %overflow.1
172+
}
173+
174+
175+
176+
define i1 @test4_no_icmp_ne(i64 %a, i64 %b, i64* %ptr) {
177+
; CHECK-LABEL: @test4_no_icmp_ne(
178+
; CHECK-NEXT: [[RES:%.*]] = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 [[A:%.*]], i64 [[B:%.*]])
179+
; CHECK-NEXT: [[OVERFLOW:%.*]] = extractvalue { i64, i1 } [[RES]], 1
180+
; CHECK-NEXT: [[MUL:%.*]] = extractvalue { i64, i1 } [[RES]], 0
181+
; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i64 [[MUL]], 0
182+
; CHECK-NEXT: [[OVERFLOW_1:%.*]] = or i1 [[OVERFLOW]], [[CMP]]
183+
; CHECK-NEXT: [[NEG:%.*]] = sub i64 0, [[MUL]]
184+
; CHECK-NEXT: store i64 [[NEG]], i64* [[PTR:%.*]], align 8
185+
; CHECK-NEXT: ret i1 [[OVERFLOW_1]]
186+
;
187+
%res = tail call { i64, i1 } @llvm.umul.with.overflow.i64(i64 %a, i64 %b)
188+
%overflow = extractvalue { i64, i1 } %res, 1
189+
%mul = extractvalue { i64, i1 } %res, 0
190+
%cmp = icmp sgt i64 %mul, 0
191+
%overflow.1 = or i1 %overflow, %cmp
192+
%neg = sub i64 0, %mul
193+
store i64 %neg, i64* %ptr, align 8
194+
ret i1 %overflow.1
195+
}
196+
197+
attributes #0 = { nounwind readnone speculatable willreturn }

0 commit comments

Comments
 (0)