Skip to content

Commit b0f64ad

Browse files
committed
get rid of linux specific file in test.
1 parent 4b47fcc commit b0f64ad

File tree

3 files changed

+21
-2
lines changed

3 files changed

+21
-2
lines changed

libc/test/src/sys/uio/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ add_libc_unittest(
1313
libc.src.fcntl.open
1414
libc.src.sys.uio.writev
1515
libc.src.unistd.close
16+
libc.src.unistd.unlink
1617
libc.test.UnitTest.ErrnoSetterMatcher
1718
)
1819

@@ -29,5 +30,7 @@ add_libc_unittest(
2930
libc.src.fcntl.open
3031
libc.src.sys.uio.readv
3132
libc.src.unistd.close
33+
libc.src.unistd.unlink
34+
libc.src.unistd.write
3235
libc.test.UnitTest.ErrnoSetterMatcher
3336
)

libc/test/src/sys/uio/readv_test.cpp

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,23 @@
1010
#include "src/fcntl/open.h"
1111
#include "src/sys/uio/readv.h"
1212
#include "src/unistd/close.h"
13+
#include "src/unistd/unlink.h"
14+
#include "src/unistd/write.h"
1315
#include "test/UnitTest/ErrnoSetterMatcher.h"
1416
#include "test/UnitTest/Test.h"
1517

1618
using namespace LIBC_NAMESPACE::testing::ErrnoSetterMatcher;
1719

1820
TEST(LlvmLibcSysUioReadvTest, SmokeTest) {
19-
int fd = LIBC_NAMESPACE::open("/dev/urandom", O_RDONLY);
21+
const char *filename = "./LlvmLibcSysUioReadvTest";
22+
int fd = LIBC_NAMESPACE::open(filename, O_WRONLY | O_CREAT, 0644);
23+
ASSERT_THAT(fd, returns(GT(0)).with_errno(EQ(0)));
24+
const char data[] = "Hello, World!\n";
25+
ASSERT_THAT(LIBC_NAMESPACE::write(fd, data, sizeof(data)),
26+
returns(EQ(sizeof(data))).with_errno(EQ(0)));
27+
ASSERT_THAT(LIBC_NAMESPACE::close(fd), Succeeds());
28+
29+
fd = LIBC_NAMESPACE::open(filename, O_RDONLY);
2030
ASSERT_THAT(fd, returns(GT(0)).with_errno(EQ(0)));
2131
char buf0[2];
2232
char buf1[3];
@@ -28,4 +38,6 @@ TEST(LlvmLibcSysUioReadvTest, SmokeTest) {
2838
ASSERT_THAT(LIBC_NAMESPACE::readv(fd, iov, 2),
2939
returns(EQ(3)).with_errno(EQ(0)));
3040
ASSERT_THAT(LIBC_NAMESPACE::close(fd), Succeeds());
41+
ASSERT_THAT(LIBC_NAMESPACE::unlink(filename),
42+
returns(EQ(0)).with_errno(EQ(0)));
3143
}

libc/test/src/sys/uio/writev_test.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,15 @@
1010
#include "src/fcntl/open.h"
1111
#include "src/sys/uio/writev.h"
1212
#include "src/unistd/close.h"
13+
#include "src/unistd/unlink.h"
1314
#include "test/UnitTest/ErrnoSetterMatcher.h"
1415
#include "test/UnitTest/Test.h"
1516

1617
using namespace LIBC_NAMESPACE::testing::ErrnoSetterMatcher;
1718

1819
TEST(LlvmLibcSysUioWritevTest, SmokeTest) {
19-
int fd = LIBC_NAMESPACE::open("/dev/null", O_WRONLY);
20+
const char *filename = "./LlvmLibcSysUioWritevTest";
21+
int fd = LIBC_NAMESPACE::open(filename, O_WRONLY | O_CREAT, 0644);
2022
ASSERT_THAT(fd, returns(GT(0)).with_errno(EQ(0)));
2123
const char *data = "Hello, World!\n";
2224
struct iovec iov[2];
@@ -27,4 +29,6 @@ TEST(LlvmLibcSysUioWritevTest, SmokeTest) {
2729
ASSERT_THAT(LIBC_NAMESPACE::writev(fd, iov, 2),
2830
returns(EQ(15)).with_errno(EQ(0)));
2931
ASSERT_THAT(LIBC_NAMESPACE::close(fd), Succeeds());
32+
ASSERT_THAT(LIBC_NAMESPACE::unlink(filename),
33+
returns(EQ(0)).with_errno(EQ(0)));
3034
}

0 commit comments

Comments
 (0)