Skip to content

Commit b136c0d

Browse files
dzhidzhoevyuxuanchen1997
authored andcommitted
[LLDB][test] Drop OS/HOST_OS detection code from Makefile.rules (#99535)
Summary: Remove commands for OS/HOST_OS detection from Makefile.rules to simplify it, since logic for these variables has been implemented in `lldb/packages/Python/lldbsuite/test/lldbplatformutil.py` (7021e44). Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250890
1 parent f318463 commit b136c0d

File tree

1 file changed

+0
-25
lines changed

1 file changed

+0
-25
lines changed

lldb/packages/Python/lldbsuite/test/make/Makefile.rules

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -46,31 +46,6 @@ LLDB_BASE_DIR := $(THIS_FILE_DIR)/../../../../../
4646
# according to variable values).
4747
.DEFAULT_GOAL := all
4848

49-
#----------------------------------------------------------------------
50-
# If OS is not defined, use 'uname -s' to determine the OS name.
51-
#
52-
# GNUWin32 uname gives "windows32" or "server version windows32" while
53-
# some versions of MSYS uname return "MSYS_NT*", but most environments
54-
# standardize on "Windows_NT", so we'll make it consistent here.
55-
# When running tests from Visual Studio, the environment variable isn't
56-
# inherited all the way down to the process spawned for make.
57-
#----------------------------------------------------------------------
58-
ifeq "$(HOST_OS)" ""
59-
HOST_OS := $(shell uname -s)
60-
endif
61-
62-
ifneq (,$(findstring windows32,$(HOST_OS)))
63-
HOST_OS := Windows_NT
64-
endif
65-
66-
ifneq (,$(findstring MSYS_NT,$(HOST_OS)))
67-
HOST_OS := Windows_NT
68-
endif
69-
70-
ifeq "$(OS)" ""
71-
OS := $(HOST_OS)
72-
endif
73-
7449
#----------------------------------------------------------------------
7550
# If OS is Windows, force SHELL to be cmd
7651
#

0 commit comments

Comments
 (0)