[SLP][NFC]Remove unnecessary std::optional around Factor value

alexey-bataev · alexey-bataev · commit b17f60770362 · 2024-11-20T05:54:15.000-08:00
diff --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -10296,10 +10296,10 @@ class BoUpSLP::ShuffleCostEstimator : public BaseShuffleAnalysis {
             Idx = EMask[Idx];
         }
         CommonVF = E->Scalars.size();
-      } else if (std::optional<unsigned> Factor = E->getInterleaveFactor();
-                 Factor && E->Scalars.size() != Mask.size() &&
+      } else if (unsigned Factor = E->getInterleaveFactor();
+                 Factor > 0 && E->Scalars.size() != Mask.size() &&
                  ShuffleVectorInst::isDeInterleaveMaskOfFactor(CommonMask,
-                                                               *Factor)) {
+                                                               Factor)) {
         // Deinterleaved nodes are free.
         std::iota(CommonMask.begin(), CommonMask.end(), 0);
       }

Original file line number	Diff line number	Diff line change
`@@ -10296,10 +10296,10 @@ class BoUpSLP::ShuffleCostEstimator : public BaseShuffleAnalysis {`
`10296`	`10296`	`Idx = EMask[Idx];`
`10297`	`10297`	`}`
`10298`	`10298`	`CommonVF = E->Scalars.size();`
`10299`		`- } else if (std::optional<unsigned> Factor = E->getInterleaveFactor();`
`10300`		`- Factor && E->Scalars.size() != Mask.size() &&`
	`10299`	`+ } else if (unsigned Factor = E->getInterleaveFactor();`
	`10300`	`+ Factor > 0 && E->Scalars.size() != Mask.size() &&`
`10301`	`10301`	`ShuffleVectorInst::isDeInterleaveMaskOfFactor(CommonMask,`
`10302`		`- *Factor)) {`
	`10302`	`+ Factor)) {`
`10303`	`10303`	`// Deinterleaved nodes are free.`
`10304`	`10304`	`std::iota(CommonMask.begin(), CommonMask.end(), 0);`
`10305`	`10305`	`}`