Add unknown comments

Author: SLTozer

llvm/lib/Transforms/Utils/InlineFunction.cpp

@@ -3344,10 +3344,14 @@ llvm::InlineResult llvm::InlineFunction(CallBase &CB, InlineFunctionInfo &IFI,
     Returns[0]->eraseFromParent();
     ReturnBB->eraseFromParent();
   } else if (!CB.use_empty()) {
-    // No returns, but something is using the return value of the call.  Just
-    // nuke the result.
+    // In this case there are no returns to use, so there is no clear source
+    // location for the "return".
+    // FIXME: It may be correct to use the scope end line of the function here,
+    // since this likely means we are falling out of the function.
     if (CreatedBranchToNormalDest)
       CreatedBranchToNormalDest->setDebugLoc(DebugLoc::getUnknown());
+    // No returns, but something is using the return value of the call.  Just
+    // nuke the result.
     CB.replaceAllUsesWith(PoisonValue::get(CB.getType()));
   }
 

llvm/lib/Transforms/Utils/SSAUpdater.cpp

@@ -318,6 +318,10 @@ class SSAUpdaterTraits<SSAUpdater> {
                                SSAUpdater *Updater) {
     PHINode *PHI =
         PHINode::Create(Updater->ProtoType, NumPreds, Updater->ProtoName);
+    // FIXME: Ordinarily we don't care about or try to assign DebugLocs to PHI
+    // nodes, but loop optimizations may try to use a PHI node as a DebugLoc
+    // source (e.g. if this is an induction variable), and it's not clear what
+    // location we could attach here, so mark this unknown for now.
     PHI->setDebugLoc(DebugLoc::getUnknown());
     PHI->insertBefore(BB->begin());
     return PHI;