Another round of feedback, remove instrumentation and reorder private vs public methods, move assert closer to comment and check process_sp in plu pluginmanager.cpp

Author: Jlalond

lldb/source/API/SBCoreDumpOptions.cpp

@@ -75,12 +75,11 @@ lldb::SaveCoreStyle SBCoreDumpOptions::GetStyle() const {
   return m_opaque_up->GetStyle();
 }
 
-lldb_private::CoreDumpOptions &SBCoreDumpOptions::ref() const {
-  LLDB_INSTRUMENT_VA(this);
-  return *m_opaque_up.get();
-}
-
 void SBCoreDumpOptions::Clear() {
   LLDB_INSTRUMENT_VA(this);
   m_opaque_up->Clear();
 }
+
+lldb_private::CoreDumpOptions &SBCoreDumpOptions::ref() const {
+  return *m_opaque_up.get();
+}

lldb/source/Core/PluginManager.cpp

@@ -709,6 +709,9 @@ Status PluginManager::SaveCore(const lldb::ProcessSP &process_sp,
     return error;
   }
 
+  if (!process_sp) 
+    return error;
+
   if (!options.GetPluginName().has_value()) {
     // Try saving core directly from the process plugin first.
     llvm::Expected<bool> ret =

lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

@@ -6526,8 +6526,8 @@ bool ObjectFileMachO::SaveCore(const lldb::ProcessSP &process_sp,
     core_style = SaveCoreStyle::eSaveCoreDirtyOnly;
   // The FileSpec and Process are already checked in PluginManager::SaveCore.
   assert(options.GetOutputFile().has_value());
-  const FileSpec outfile = options.GetOutputFile().value();
   assert(process_sp);
+  const FileSpec outfile = options.GetOutputFile().value();
 
   Target &target = process_sp->GetTarget();
   const ArchSpec target_arch = target.GetArchitecture();