Skip to content

Commit b301547

Browse files
committed
use SBMemoryRegionInfo equality operator in test
1 parent 16792f7 commit b301547

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

lldb/test/API/python_api/find_in_memory/TestFindInMemory.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -163,23 +163,24 @@ def test_memory_info_list_iterable(self):
163163

164164
collected_info = []
165165
try:
166-
for region in info_list:
167-
collected_info.append(region)
166+
for info in info_list:
167+
collected_info.append(info)
168168
except Exception:
169169
self.fail("SBMemoryRegionInfoList is not iterable")
170-
171-
self.assertTrue(len(collected_info) >= 2, "Need at least 2 items")
172-
self.assertEqual(len(collected_info), info_list.GetSize(), "Should have collected all items")
173170

174171
for i in range(len(collected_info)):
175172
region = lldb.SBMemoryRegionInfo()
176173
info_list.GetMemoryRegionAtIndex(i, region)
177-
178-
self.assertEqual(collected_info[i].GetRegionBase(), region.GetRegionBase(),
179-
f"items {i}: iterator data should match index access data")
180-
self.assertEqual(collected_info[i].GetRegionEnd(), region.GetRegionEnd(),
181-
f"items {i}: iterator data should match index access data")
182-
174+
175+
self.assertEqual(
176+
collected_info[i],
177+
region,
178+
f"items {i}: iterator data should match index access data",
179+
)
180+
183181
if len(collected_info) >= 2:
184-
self.assertNotEqual(collected_info[0].GetRegionBase(), collected_info[1].GetRegionBase(),
185-
"Different items should have different base addresses")
182+
self.assertNotEqual(
183+
collected_info[0].GetRegionBase(),
184+
collected_info[1].GetRegionBase(),
185+
"Different items should have different base addresses",
186+
)

0 commit comments

Comments
 (0)