Skip to content

Commit b312cbf

Browse files
authored
[NFC][CGSCC] Remove RCWorklist from CGSCCUpdateResult (#95448)
After #94815, this is only used within ModuleToPostOrderCGSCCPassAdaptor::run(), so keep it local to that function.
1 parent f985a88 commit b312cbf

File tree

2 files changed

+8
-15
lines changed

2 files changed

+8
-15
lines changed

llvm/include/llvm/Analysis/CGSCCPassManager.h

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -230,17 +230,6 @@ using ModuleAnalysisManagerCGSCCProxy =
230230
/// Passes which do not change the call graph structure in any way can just
231231
/// ignore this argument to their run method.
232232
struct CGSCCUpdateResult {
233-
/// Worklist of the RefSCCs queued for processing.
234-
///
235-
/// When a pass refines the graph and creates new RefSCCs or causes them to
236-
/// have a different shape or set of component SCCs it should add the RefSCCs
237-
/// to this worklist so that we visit them in the refined form.
238-
///
239-
/// This worklist is in reverse post-order, as we pop off the back in order
240-
/// to observe RefSCCs in post-order. When adding RefSCCs, clients should add
241-
/// them in reverse post-order.
242-
SmallPriorityWorklist<LazyCallGraph::RefSCC *, 1> &RCWorklist;
243-
244233
/// Worklist of the SCCs queued for processing.
245234
///
246235
/// When a pass refines the graph and creates new SCCs or causes them to have

llvm/lib/Analysis/CGSCCPassManager.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,10 +160,14 @@ ModuleToPostOrderCGSCCPassAdaptor::run(Module &M, ModuleAnalysisManager &AM) {
160160

161161
SmallVector<Function *, 4> DeadFunctions;
162162

163-
CGSCCUpdateResult UR = {
164-
RCWorklist, CWorklist, InvalidRefSCCSet,
165-
InvalidSCCSet, nullptr, PreservedAnalyses::all(),
166-
InlinedInternalEdges, DeadFunctions, {}};
163+
CGSCCUpdateResult UR = {CWorklist,
164+
InvalidRefSCCSet,
165+
InvalidSCCSet,
166+
nullptr,
167+
PreservedAnalyses::all(),
168+
InlinedInternalEdges,
169+
DeadFunctions,
170+
{}};
167171

168172
// Request PassInstrumentation from analysis manager, will use it to run
169173
// instrumenting callbacks for the passes later.

0 commit comments

Comments
 (0)