Missed an if around bitcast

krzysz00 · krzysz00 · commit b37c54513476 · 2024-10-04T17:41:29.000Z
diff --git a/llvm/lib/Target/AMDGPU/AMDGPULowerBufferFatPointers.cpp b/llvm/lib/Target/AMDGPU/AMDGPULowerBufferFatPointers.cpp
@@ -781,9 +781,7 @@ Value *LegalizeBufferContentTypesVisitor::makeIllegalNonAggregate(
         IRB.getIntNTy(DL.getTypeSizeInBits(LegalType).getFixedValue());
     Value *AsScalar = IRB.CreateBitCast(V, ByteScalarTy, Name + ".bytes.cast");
     Value *Trunc = IRB.CreateTrunc(AsScalar, ShortScalarTy, Name + ".trunc");
-    if (OrigType != ShortScalarTy)
-      return IRB.CreateBitCast(Trunc, OrigType, Name + ".orig");
-    return Trunc;
+    return IRB.CreateBitCast(Trunc, OrigType, Name + ".orig");
   }
   return IRB.CreateBitCast(V, OrigType, Name + ".real.ty");
 }

Original file line number	Diff line number	Diff line change
`@@ -781,9 +781,7 @@ Value *LegalizeBufferContentTypesVisitor::makeIllegalNonAggregate(`
`781`	`781`	`IRB.getIntNTy(DL.getTypeSizeInBits(LegalType).getFixedValue());`
`782`	`782`	`Value *AsScalar = IRB.CreateBitCast(V, ByteScalarTy, Name + ".bytes.cast");`
`783`	`783`	`Value *Trunc = IRB.CreateTrunc(AsScalar, ShortScalarTy, Name + ".trunc");`
`784`		`- if (OrigType != ShortScalarTy)`
`785`		`- return IRB.CreateBitCast(Trunc, OrigType, Name + ".orig");`
`786`		`- return Trunc;`
	`784`	`+ return IRB.CreateBitCast(Trunc, OrigType, Name + ".orig");`
`787`	`785`	`}`
`788`	`786`	`return IRB.CreateBitCast(V, OrigType, Name + ".real.ty");`
`789`	`787`	`}`