Skip to content

Commit b3994ae

Browse files
committed
address comments
1 parent 6e896ae commit b3994ae

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -583,15 +583,15 @@ void NVPTXAsmPrinter::emitKernelFunctionDirectives(const Function &F,
583583
O << ".explicitcluster\n";
584584
if (ClusterX.value_or(1) != 0) {
585585
assert(ClusterY.value_or(1) && ClusterZ.value_or(1) &&
586-
"clusterx != 0 implies clustery and clusterz should be non-zero "
587-
"as well");
586+
"cluster_dim_x != 0 implies cluster_dim_y and cluster_dim_z "
587+
"should be non-zero as well");
588588

589589
O << ".reqnctapercluster " << ClusterX.value_or(1) << ", "
590590
<< ClusterY.value_or(1) << ", " << ClusterZ.value_or(1) << "\n";
591591
} else {
592-
assert(
593-
!ClusterY.value_or(1) && !ClusterZ.value_or(1) &&
594-
"clusterx == 0 implies clustery and clusterz should be 0 as well");
592+
assert(!ClusterY.value_or(1) && !ClusterZ.value_or(1) &&
593+
"cluster_dim_x == 0 implies cluster_dim_y and cluster_dim_z "
594+
"should be 0 as well");
595595
}
596596
}
597597
if (const auto Maxclusterrank = getMaxClusterRank(F))

llvm/test/CodeGen/NVPTX/cluster-dim.ll

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
; RUN: llc < %s -march=nvptx -mcpu=sm_90 | FileCheck %s
21
; RUN: llc < %s -march=nvptx64 -mcpu=sm_90 | FileCheck %s
3-
; RUN: %if ptxas %{ llc < %s -march=nvptx -mcpu=sm_90 | %ptxas-verify %}
4-
; RUN: %if ptxas %{ llc < %s -march=nvptx64 -mcpu=sm_90 | %ptxas-verify %}
2+
; RUN: %if ptxas-12.0 %{ llc < %s -march=nvptx64 -mcpu=sm_90 | %ptxas-verify -arch=sm_90 %}
53

64
; CHECK-LABEL: .entry kernel_func_clusterxyz
75
define void @kernel_func_clusterxyz() {

0 commit comments

Comments
 (0)