Skip to content

Commit b3a2fed

Browse files
committed
Address code review comments
1 parent a2eaa7f commit b3a2fed

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

clang/lib/CIR/Dialect/IR/CIRDialect.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#include "clang/CIR/Dialect/IR/CIROpsDialect.cpp.inc"
2222
#include "clang/CIR/Dialect/IR/CIROpsEnums.cpp.inc"
2323
#include "clang/CIR/MissingFeatures.h"
24+
2425
#include <numeric>
2526

2627
using namespace mlir;
@@ -1597,9 +1598,9 @@ OpFoldResult cir::VecShuffleDynamicOp::fold(FoldAdaptor adaptor) {
15971598
elements.reserve(numElements);
15981599

15991600
const uint64_t maskBits = llvm::NextPowerOf2(numElements - 1) - 1;
1600-
for (uint64_t i = 0; i < numElements; i++) {
1601-
cir::IntAttr idxAttr = mlir::cast<cir::IntAttr>(indicesElts[i]);
1602-
uint64_t idxValue = idxAttr.getUInt();
1601+
for (const mlir::APInt &idxAttr :
1602+
indicesElts.getAsValueRange<cir::IntAttr, mlir::APInt>()) {
1603+
uint64_t idxValue = idxAttr.getZExtValue();
16031604
uint64_t newIdx = idxValue & maskBits;
16041605
elements.push_back(vecElts[newIdx]);
16051606
}

0 commit comments

Comments
 (0)