Skip to content

Commit b3bf1db

Browse files
committed
Handle review comments.
Add a TODO comment that we still need to handle variable lower bound.
1 parent 3b40541 commit b3bf1db

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

flang/lib/Optimizer/Transforms/DebugTypeGenerator.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,8 @@ mlir::LLVM::DITypeAttr DebugTypeGenerator::convertBoxedSequenceType(
123123
mlir::Attribute lowerAttr = nullptr;
124124
// If declaration has a lower bound, use it.
125125
if (declOp && declOp.getShift().size() > index) {
126+
// TODO: Handle case where lower bound is a variable (instead of a
127+
// constant as handled here)
126128
if (std::optional<std::int64_t> optint =
127129
getIntIfConstant(declOp.getShift()[index]))
128130
lowerAttr = mlir::IntegerAttr::get(intTy, llvm::APInt(64, *optint));

0 commit comments

Comments
 (0)