Address code review comments

Author: AmrDeveloper

clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp

@@ -49,15 +49,15 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID,
     }
   }
 
-  mlir::Location loc = getLoc(e->getExprLoc());
   switch (builtinID) {
   case Builtin::BI__builtin_complex: {
     mlir::Value real = emitScalarExpr(e->getArg(0));
     mlir::Value imag = emitScalarExpr(e->getArg(1));
     return RValue::getComplex(real, imag);
   }
-  default:
-    cgm.errorNYI(loc, "non constant foldable builtin calls");
   }
+
+  mlir::Location loc = getLoc(e->getExprLoc());
+  cgm.errorNYI(loc, "non constant foldable builtin calls");
   return getUndefRValue(e->getType());
 }

clang/lib/CIR/CodeGen/CIRGenExprComplex.cpp

@@ -52,7 +52,7 @@ mlir::Value ComplexExprEmitter::emitLoadOfLValue(LValue lv,
                                                  SourceLocation loc) {
   assert(lv.isSimple() && "non-simple complex l-value?");
   if (lv.getType()->isAtomicType())
-    cgf.cgm.errorNYI("emitLoadOfLValue with Atomic LV");
+    cgf.cgm.errorNYI(loc, "emitLoadOfLValue with Atomic LV");
 
   const Address srcAddr = lv.getAddress();
   return builder.createLoad(cgf.getLoc(loc), srcAddr);
@@ -62,7 +62,7 @@ void ComplexExprEmitter::emitStoreOfComplex(mlir::Location loc, mlir::Value val,
                                             LValue lv, bool isInit) {
   if (lv.getType()->isAtomicType() ||
       (!isInit && cgf.isLValueSuitableForInlineAtomic(lv))) {
-    cgf.cgm.errorNYI("StoreOfComplex with Atomic LV");
+    cgf.cgm.errorNYI(loc, "StoreOfComplex with Atomic LV");
     return;
   }
 

clang/lib/CIR/CodeGen/CIRGenValue.h

@@ -96,7 +96,6 @@ class RValue {
     er.isVolatile = false;
     return er;
   }
-
   static RValue getComplex(const std::pair<mlir::Value, mlir::Value> &c) {
     return getComplex(c.first, c.second);
   }

clang/test/CIR/CodeGen/complex.cpp

@@ -191,8 +191,8 @@ void foo8() {
 // OGCG: store double 0.000000e+00, ptr %[[C_REAL_PTR]], align 8
 // OGCG: store double 2.000000e+00, ptr %[[C_IMAG_PTR]], align 8
 
-void foo9(double r, double i) {
-  double _Complex c = __builtin_complex(r, i);
+void foo9(double a, double b) {
+  double _Complex c = __builtin_complex(a, b);
 }
 
 // CIR: %[[INIT:.*]] = cir.alloca !cir.complex<!cir.double>, !cir.ptr<!cir.complex<!cir.double>>, ["c", init]