Skip to content

Commit b43bec1

Browse files
committed
[ARM] Add Tag_CPU_arch missing value descriptions in attribute parser
The ARM attribute parser for Tag_CPU_arch is missing value descriptions for Armv8-A and Armv8-R. This patch adds these descriptions. Reviewed By: pratlucas Differential Revision: https://reviews.llvm.org/D129631
1 parent e80dbfd commit b43bec1

File tree

3 files changed

+23
-1
lines changed

3 files changed

+23
-1
lines changed

llvm/lib/Support/ARMAttributeParser.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ Error ARMAttributeParser::CPU_arch(AttrType tag) {
8585
static const char *strings[] = {
8686
"Pre-v4", "ARM v4", "ARM v4T", "ARM v5T", "ARM v5TE", "ARM v5TEJ", "ARM v6",
8787
"ARM v6KZ", "ARM v6T2", "ARM v6K", "ARM v7", "ARM v6-M", "ARM v6S-M",
88-
"ARM v7E-M", "ARM v8", nullptr,
88+
"ARM v7E-M", "ARM v8-A", "ARM v8-R",
8989
"ARM v8-M Baseline", "ARM v8-M Mainline", nullptr, nullptr, nullptr,
9090
"ARM v8.1-M Mainline", "ARM v9-A"
9191
};
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
@ RUN: llvm-mc -triple arm -filetype asm -o - %s | FileCheck %s
2+
@ RUN: llvm-mc -triple arm -filetype obj -o - %s | llvm-readobj -A - | \
3+
@ RUN: FileCheck %s --check-prefix=CHECK-OBJ
4+
5+
.eabi_attribute Tag_CPU_arch, 14
6+
@ CHECK: .eabi_attribute 6, 14 @ Tag_CPU_arch
7+
@ CHECK-OBJ: Attribute
8+
@ CHECK-OBJ: Tag: 6
9+
@ CHECK-OBJ-NEXT: Value: 14
10+
@ CHECK-OBJ-NEXT: TagName: CPU_arch
11+
@ CHECK-OBJ-NEXT: Description: ARM v8-A
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
@ RUN: llvm-mc -triple arm -filetype asm -o - %s | FileCheck %s
2+
@ RUN: llvm-mc -triple arm -filetype obj -o - %s | llvm-readobj -A - | \
3+
@ RUN: FileCheck %s --check-prefix=CHECK-OBJ
4+
5+
.eabi_attribute Tag_CPU_arch, 15
6+
@ CHECK: .eabi_attribute 6, 15 @ Tag_CPU_arch
7+
@ CHECK-OBJ: Attribute
8+
@ CHECK-OBJ: Tag: 6
9+
@ CHECK-OBJ-NEXT: Value: 15
10+
@ CHECK-OBJ-NEXT: TagName: CPU_arch
11+
@ CHECK-OBJ-NEXT: Description: ARM v8-R

0 commit comments

Comments
 (0)