Explicitly exclude function arguments

Author: PiotrZSL

clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp

@@ -53,9 +53,8 @@ void AvoidCArraysCheck::registerMatchers(MatchFinder *Finder) {
       anything();
   if (AllowStringArrays)
     IgnoreStringArrayIfNeededMatcher =
-        unless(typeLoc(loc(hasCanonicalType(incompleteArrayType(
-                           hasElementType(isAnyCharacter())))),
-                       hasParent(varDecl(hasInitializer(stringLiteral())))));
+        unless(typeLoc(loc(hasCanonicalType(incompleteArrayType(hasElementType(isAnyCharacter())))),
+                       hasParent(varDecl(hasInitializer(stringLiteral()), unless(parmVarDecl())))));
 
   Finder->addMatcher(
       typeLoc(hasValidBeginLoc(), hasType(arrayType()),

clang-tools-extra/test/clang-tidy/checkers/modernize/avoid-c-arrays-ignores-strings.cpp

@@ -4,3 +4,6 @@
 const char name[] = "name";
 const char array[] = {'n', 'a', 'm', 'e', '\0'};
 // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: do not declare C-style arrays, use std::array<> instead [modernize-avoid-c-arrays]
+
+void takeCharArray(const char name[]);
+// CHECK-MESSAGES: :[[@LINE-1]]:26: warning: do not declare C-style arrays, use std::array<> instead [modernize-avoid-c-arrays]

clang-tools-extra/test/clang-tidy/checkers/modernize/avoid-c-arrays.cpp

@@ -89,3 +89,6 @@ struct Bar {
 
 const char name[] = "Some string";
 // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: do not declare C-style arrays, use std::array<> instead [modernize-avoid-c-arrays]
+
+void takeCharArray(const char name[]);
+// CHECK-MESSAGES: :[[@LINE-1]]:26: warning: do not declare C-style arrays, use std::array<> instead [modernize-avoid-c-arrays]