Renamed to test pass

Author: Hardcode84

mlir/include/mlir/Dialect/SCF/Transforms/Passes.td

@@ -154,7 +154,7 @@ def SCFForToWhileLoop : Pass<"scf-for-to-while"> {
   }];
 }
 
-def SCFUpliftWhileToFor : Pass<"scf-uplift-while-to-for"> {
+def TestSCFUpliftWhileToFor : Pass<"test-scf-uplift-while-to-for"> {
   let summary = "Uplift scf.while ops to scf.for";
   let description = [{
     This pass tries to uplift `scf.while` ops to `scf.for` if they have a

mlir/include/mlir/Dialect/SCF/Transforms/Patterns.h

@@ -80,6 +80,9 @@ void populateSCFLoopPipeliningPatterns(RewritePatternSet &patterns,
 void populateSCFForLoopCanonicalizationPatterns(RewritePatternSet &patterns);
 
 /// Populate patterns to uplift `scf.while` ops to `scf.for`.
+/// Uplifitng expects a specific ops pattern:
+///  * `before` block consisting of single arith.cmp op
+///  * `after` block containing arith.addi
 void populateUpliftWhileToForPatterns(RewritePatternSet &patterns);
 
 } // namespace scf

mlir/lib/Dialect/SCF/Transforms/UpliftWhileToFor.cpp

@@ -20,7 +20,7 @@
 #include "mlir/Transforms/GreedyPatternRewriteDriver.h"
 
 namespace mlir {
-#define GEN_PASS_DEF_SCFUPLIFTWHILETOFOR
+#define GEN_PASS_DEF_TESTSCFUPLIFTWHILETOFOR
 #include "mlir/Dialect/SCF/Transforms/Passes.h.inc"
 } // namespace mlir
 
@@ -218,9 +218,9 @@ struct UpliftWhileOp : public OpRewritePattern<scf::WhileOp> {
   }
 };
 
-struct SCFUpliftWhileToFor final
-    : impl::SCFUpliftWhileToForBase<SCFUpliftWhileToFor> {
-  using SCFUpliftWhileToForBase::SCFUpliftWhileToForBase;
+struct TestSCFUpliftWhileToFor final
+    : impl::TestSCFUpliftWhileToForBase<TestSCFUpliftWhileToFor> {
+  using TestSCFUpliftWhileToForBase::TestSCFUpliftWhileToForBase;
 
   void runOnOperation() override {
     Operation *op = getOperation();

mlir/test/Dialect/SCF/uplift-while.mlir

@@ -1,4 +1,4 @@
-// RUN: mlir-opt %s -pass-pipeline='builtin.module(func.func(scf-uplift-while-to-for))' -split-input-file -allow-unregistered-dialect | FileCheck %s
+// RUN: mlir-opt %s -pass-pipeline='builtin.module(func.func(test-scf-uplift-while-to-for))' -split-input-file -allow-unregistered-dialect | FileCheck %s
 
 func.func @uplift_while(%arg0: index, %arg1: index, %arg2: index) -> index {
   %0 = scf.while (%arg3 = %arg0) : (index) -> (index) {