Skip to content

Commit b5ffce4

Browse files
committed
review: use EXPECT_FLOAT_EQ
1 parent 5733ae3 commit b5ffce4

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -254,8 +254,8 @@ TEST_F(ParseHLSLRootSignatureTest, ValidParseStaticSamplerTest) {
254254
ASSERT_EQ(std::get<StaticSampler>(Elem).Reg.Number, 0u);
255255
ASSERT_EQ(std::get<StaticSampler>(Elem).MipLODBias, 0.f);
256256
ASSERT_EQ(std::get<StaticSampler>(Elem).MaxAnisotropy, 16u);
257-
ASSERT_EQ(std::get<StaticSampler>(Elem).MinLOD, 0.f);
258-
ASSERT_EQ(std::get<StaticSampler>(Elem).MaxLOD, 3.402823466e+38f);
257+
ASSERT_FLOAT_EQ(std::get<StaticSampler>(Elem).MinLOD, 0.f);
258+
ASSERT_FLOAT_EQ(std::get<StaticSampler>(Elem).MaxLOD, 3.402823466e+38f);
259259

260260
// Check values can be set as expected
261261
Elem = Elements[1];
@@ -264,8 +264,8 @@ TEST_F(ParseHLSLRootSignatureTest, ValidParseStaticSamplerTest) {
264264
ASSERT_EQ(std::get<StaticSampler>(Elem).Reg.Number, 0u);
265265
ASSERT_EQ(std::get<StaticSampler>(Elem).MipLODBias, 230.f);
266266
ASSERT_EQ(std::get<StaticSampler>(Elem).MaxAnisotropy, 3u);
267-
ASSERT_EQ(std::get<StaticSampler>(Elem).MinLOD, 4.2f);
268-
ASSERT_EQ(std::get<StaticSampler>(Elem).MaxLOD, 9000.f);
267+
ASSERT_FLOAT_EQ(std::get<StaticSampler>(Elem).MinLOD, 4.2f);
268+
ASSERT_FLOAT_EQ(std::get<StaticSampler>(Elem).MaxLOD, 9000.f);
269269

270270
ASSERT_TRUE(Consumer->isSatisfied());
271271
}

0 commit comments

Comments
 (0)