Skip to content

Commit b6209ad

Browse files
committed
Add a comment to tests that XPASS on FreeBSD
Perhaps these should be @expectedFailureDarwin instead of @unittest2.expectedFailure (applying to all hosts); I'm not aware of the details in the rdars. Just add a comment for now, for the benefit of anyone investigating FreeBSD test issues in the future. rdar://9980907 rdar://15367233 llvm-svn: 206760
1 parent 3939f54 commit b6209ad

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lldb/test/functionalities/inferior-assert/TestInferiorAssert.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def test_inferior_asserting_dsym(self):
1717
self.inferior_asserting()
1818

1919
@expectedFailurei386 # llvm.org/pr17384: lldb needs to be aware of linux-vdso.so to unwind stacks properly'
20-
@unittest2.expectedFailure("rdar://15367233")
20+
@unittest2.expectedFailure("rdar://15367233") # XPASS on FreeBSD w/ Clang 3.4 and libc++
2121
def test_inferior_asserting_dwarf(self):
2222
"""Test that lldb reliably catches the inferior asserting (command)."""
2323
self.buildDwarf()
@@ -70,7 +70,7 @@ def test_inferior_asserting_step(self):
7070
self.inferior_asserting_step()
7171

7272
@expectedFailurei386 # llvm.org/pr17384: lldb needs to be aware of linux-vdso.so to unwind stacks properly
73-
@unittest2.expectedFailure("rdar://15367233")
73+
@unittest2.expectedFailure("rdar://15367233") # XPASS on FreeBSD w/ Clang 3.4 and libc++
7474
def test_inferior_asserting_step(self):
7575
"""Test that lldb functions correctly after stepping through a call to assert()."""
7676
self.buildDwarf()

lldb/test/lang/cpp/class_static/TestStaticVariables.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def test_with_dsym_and_python_api(self):
3838
self.buildDsym()
3939
self.static_variable_python()
4040

41-
@expectedFailureClang(9980907)
41+
@expectedFailureClang(9980907) # XPASS on FreeBSD w/ Clang 3.4 and libc++
4242
@python_api_test
4343
@dwarf_test
4444
def test_with_dwarf_and_python_api(self):

0 commit comments

Comments
 (0)