Skip to content

Commit b69bd2f

Browse files
committed
[lld][test] Avoid names that can be prefixes
The function and framework names could had matched incorrectly because ones were prefixes of the others. Use more clear and non-prefix names for the frameworks and the functions in the test.
1 parent 145dc3e commit b69bd2f

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed
Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,40 @@
11
# REQUIRES: arm
22
# RUN: rm -rf %t; split-file %s %t
3-
# RUN: ln -s Versions/A/Framework1.tbd %t/System/Library/Frameworks/Framework1.framework/
4-
# RUN: ln -s Versions/A/Framework11.tbd %t/System/Library/Frameworks/Framework11.framework/
3+
# RUN: ln -s Versions/A/FrameworkPublic.tbd %t/System/Library/Frameworks/FrameworkPublic.framework/
4+
# RUN: ln -s Versions/A/FrameworkPrivate.tbd %t/System/Library/Frameworks/FrameworkPrivate.framework/
55
# RUN: llvm-mc -filetype obj -triple arm64-apple-macos11.0 %t/test.s -o %t/test.o
6-
# RUN: %lld -arch arm64 -platform_version macos 11.0 11.0 -o %t/test -syslibroot %t -framework Framework1 %t/test.o
6+
# RUN: %lld -arch arm64 -platform_version macos 11.0 11.0 -o %t/test -syslibroot %t -framework FrameworkPublic %t/test.o
77

88
# RUN: llvm-objdump --bind --no-show-raw-insn -d %t/test | FileCheck %s
99
# CHECK: Bind table:
10-
# CHECK-DAG: __DATA __data {{.*}} pointer 0 Framework1 _func1
11-
# CHECK-DAG: __DATA __data {{.*}} pointer 0 Framework1 _func11
10+
# CHECK-DAG: __DATA __data {{.*}} pointer 0 FrameworkPublic _funcPublic
11+
# CHECK-DAG: __DATA __data {{.*}} pointer 0 FrameworkPublic _funcPrivate
1212

13-
#--- System/Library/Frameworks/Framework1.framework/Versions/A/Framework1.tbd
13+
#--- System/Library/Frameworks/FrameworkPublic.framework/Versions/A/FrameworkPublic.tbd
1414
--- !tapi-tbd
1515
tbd-version: 4
1616
targets: [ arm64-macos ]
17-
install-name: '/System/Library/Frameworks/Framework1.framework/Versions/A/Framework1'
17+
install-name: '/System/Library/Frameworks/FrameworkPublic.framework/Versions/A/FrameworkPublic'
1818
current-version: 1.0.0
1919
reexported-libraries:
2020
- targets: [ arm64-macos ]
21-
libraries: [ '/System/Library/Frameworks/Framework11.framework/Versions/A/Framework11' ]
21+
libraries: [ '/System/Library/Frameworks/FrameworkPrivate.framework/Versions/A/FrameworkPrivate' ]
2222
exports:
2323
- targets: [ arm64-macos ]
24-
symbols: [ '_func1' ]
24+
symbols: [ '_funcPublic' ]
2525
...
26-
#--- System/Library/Frameworks/Framework11.framework/Versions/A/Framework11.tbd
26+
#--- System/Library/Frameworks/FrameworkPrivate.framework/Versions/A/FrameworkPrivate.tbd
2727
--- !tapi-tbd
2828
tbd-version: 4
2929
targets: [ arm64-macos ]
30-
install-name: '/System/Library/Frameworks/Framework11.framework/Versions/A/Framework11'
30+
install-name: '/System/Library/Frameworks/FrameworkPrivate.framework/Versions/A/FrameworkPrivate'
3131
current-version: 1.0.0
3232
allowable-clients:
3333
- targets: [ arm64-macos ]
34-
clients: [ Framework1 ]
34+
clients: [ FrameworkPublic ]
3535
exports:
3636
- targets: [ arm64-macos ]
37-
symbols: [ '_func11' ]
37+
symbols: [ '_funcPrivate' ]
3838
...
3939
#--- test.s
4040
.text
@@ -44,6 +44,6 @@ _main:
4444
ret
4545

4646
.data
47-
.quad _func1
48-
.quad _func11
47+
.quad _funcPublic
48+
.quad _funcPrivate
4949

0 commit comments

Comments
 (0)