No else after return

Author: davemgreen

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

@@ -17387,13 +17387,11 @@ SDValue DAGCombiner::visitFREM(SDNode *N) {
       (Flags.hasNoSignedZeros() || DAG.isKnownNonNegativeFP(N0))) {
     SDValue Div = DAG.getNode(ISD::FDIV, DL, VT, N0, N1);
     SDValue Rnd = DAG.getNode(ISD::FTRUNC, DL, VT, Div);
-    if (TLI.isFMAFasterThanFMulAndFAdd(DAG.getMachineFunction(), VT)) {
+    if (TLI.isFMAFasterThanFMulAndFAdd(DAG.getMachineFunction(), VT))
       return DAG.getNode(ISD::FMA, DL, VT, DAG.getNode(ISD::FNEG, DL, VT, Rnd),
                          N1, N0);
-    } else {
-      SDValue Mul = DAG.getNode(ISD::FMUL, DL, VT, Rnd, N1);
-      return DAG.getNode(ISD::FSUB, DL, VT, N0, Mul);
-    }
+    SDValue Mul = DAG.getNode(ISD::FMUL, DL, VT, Rnd, N1);
+    return DAG.getNode(ISD::FSUB, DL, VT, N0, Mul);
   }
 
   return SDValue();

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

@@ -5567,7 +5567,7 @@ bool SelectionDAG::isKnownNeverZero(SDValue Op, unsigned Depth) const {
 
 bool SelectionDAG::isKnownNonNegativeFP(SDValue Op) const {
   if (ConstantFPSDNode *C1 = isConstOrConstSplatFP(Op, true))
-    return !C1->isNegative() && !C1->isNaN();
+    return !C1->isNegative();
 
   return Op.getOpcode() == ISD::FABS;
 }