Skip to content

Commit b7423e9

Browse files
authored
[AMDGPU] Remove .i32 suffix from comments documenting intrinsics (#123919)
These intrinsics are overloaded. The documentation should not single out the i32 overload.
1 parent ffde268 commit b7423e9

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

llvm/include/llvm/IR/IntrinsicsAMDGPU.td

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2563,9 +2563,10 @@ def int_amdgcn_buffer_wbinvl1_vol :
25632563
// VI Intrinsics
25642564
//===----------------------------------------------------------------------===//
25652565

2566-
// The llvm.amdgcn.mov.dpp.i32 intrinsic represents the mov.dpp operation in AMDGPU.
2567-
// This operation is being deprecated and can be replaced with llvm.amdgcn.update.dpp.i32.
2568-
// llvm.amdgcn.mov.dpp.i32 <src> <dpp_ctrl> <row_mask> <bank_mask> <bound_ctrl>
2566+
// The llvm.amdgcn.mov.dpp intrinsic represents the mov.dpp operation in AMDGPU.
2567+
// This operation is being deprecated and can be replaced with
2568+
// llvm.amdgcn.update.dpp.
2569+
// llvm.amdgcn.mov.dpp <src> <dpp_ctrl> <row_mask> <bank_mask> <bound_ctrl>
25692570
def int_amdgcn_mov_dpp :
25702571
Intrinsic<[llvm_anyint_ty],
25712572
[LLVMMatchType<0>, llvm_i32_ty, llvm_i32_ty, llvm_i32_ty,
@@ -2574,11 +2575,12 @@ def int_amdgcn_mov_dpp :
25742575
ImmArg<ArgIndex<1>>, ImmArg<ArgIndex<2>>,
25752576
ImmArg<ArgIndex<3>>, ImmArg<ArgIndex<4>>, IntrNoCallback, IntrNoFree]>;
25762577

2577-
// The llvm.amdgcn.update.dpp.i32 intrinsic represents the update.dpp operation in AMDGPU.
2578-
// It takes an old value, a source operand, a DPP control operand, a row mask, a bank mask, and a bound control.
2579-
// This operation is equivalent to a sequence of v_mov_b32 operations.
2580-
// It is preferred over llvm.amdgcn.mov.dpp.i32 for future use.
2581-
// llvm.amdgcn.update.dpp.i32 <old> <src> <dpp_ctrl> <row_mask> <bank_mask> <bound_ctrl>
2578+
// The llvm.amdgcn.update.dpp intrinsic represents the update.dpp operation in
2579+
// AMDGPU. It takes an old value, a source operand, a DPP control operand, a row
2580+
// mask, a bank mask, and a bound control. This operation is equivalent to a
2581+
// sequence of v_mov_b32 operations. It is preferred over llvm.amdgcn.mov.dpp
2582+
// for future use.
2583+
// llvm.amdgcn.update.dpp <old> <src> <dpp_ctrl> <row_mask> <bank_mask> <bound_ctrl>
25822584
// Should be equivalent to:
25832585
// v_mov_b32 <dest> <old>
25842586
// v_mov_b32 <dest> <src> <dpp_ctrl> <row_mask> <bank_mask> <bound_ctrl>
@@ -2662,7 +2664,7 @@ def int_amdgcn_permlanex16 :
26622664
[IntrNoMem, IntrConvergent, IntrWillReturn,
26632665
ImmArg<ArgIndex<4>>, ImmArg<ArgIndex<5>>, IntrNoCallback, IntrNoFree]>;
26642666

2665-
// llvm.amdgcn.mov.dpp8.i32 <src> <sel>
2667+
// llvm.amdgcn.mov.dpp8 <src> <sel>
26662668
// <sel> is a 32-bit constant whose high 8 bits must be zero which selects
26672669
// the lanes to read from.
26682670
def int_amdgcn_mov_dpp8 :

0 commit comments

Comments
 (0)