Skip to content

Commit b7f3f68

Browse files
committed
fix coding style according to comment
1 parent 31f35c2 commit b7f3f68

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1910,9 +1910,9 @@ struct SwapTransposeWithBroadcast : OpRewritePattern<linalg::TransposeOp> {
19101910
SmallVector<int64_t> resultPerms = dropDims(perms, dimensions);
19111911
SmallVector<int64_t> invertPerm = invertPermutationVector(perms);
19121912
SmallVector<int64_t> resultDimensions;
1913-
for (unsigned i = 0; i < dimensions.size(); i++) {
1913+
unsigned dimensionSize = dimensions.size();
1914+
for (unsigned i = 0; i < dimensionSize; ++i)
19141915
resultDimensions.push_back(invertPerm[dimensions[i]]);
1915-
}
19161916

19171917
// Create transpose result.
19181918
Value broadcastInput = broadcastOp.getInput();
@@ -1921,7 +1921,8 @@ struct SwapTransposeWithBroadcast : OpRewritePattern<linalg::TransposeOp> {
19211921
SmallVector<OpFoldResult> dims;
19221922
auto broadcastInputTy =
19231923
mlir::cast<RankedTensorType>(broadcastInput.getType());
1924-
for (unsigned i = 0; i < broadcastInputTy.getRank(); i++) {
1924+
unsigned inputRank = broadcastInputTy.getRank();
1925+
for (unsigned i = 0; i < inputRank; ++i) {
19251926
if (broadcastInputTy.isDynamicDim(i)) {
19261927
dims.push_back(rewriter.create<tensor::DimOp>(loc, broadcastInput, i)
19271928
->getResult(0));

mlir/lib/Dialect/Utils/IndexingUtils.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -257,11 +257,12 @@ SmallVector<int64_t> mlir::dropDims(ArrayRef<int64_t> inputPerm,
257257
assert(inputPerm.size() >= dropPositions.size() &&
258258
"expect inputPerm size large than position to drop");
259259
SmallVector<int64_t> res;
260-
for (unsigned inputIndex = 0; inputIndex < inputPerm.size(); ++inputIndex) {
260+
unsigned permSize = inputPerm.size();
261+
for (unsigned inputIndex = 0; inputIndex < permSize; ++inputIndex) {
261262
int64_t targetIndex = inputPerm[inputIndex];
262263
bool shouldDrop = false;
263-
for (unsigned dropIndex = 0; dropIndex < dropPositions.size();
264-
dropIndex++) {
264+
unsigned dropSize = dropPositions.size();
265+
for (unsigned dropIndex = 0; dropIndex < dropSize; dropIndex++) {
265266
if (dropPositions[dropIndex] == inputPerm[inputIndex]) {
266267
shouldDrop = true;
267268
break;

0 commit comments

Comments
 (0)