Skip to content

Commit b87fc09

Browse files
author
Julian Lettner
committed
Bump sanitizer macOS deployment target to 10.10
Bump default value for `SANITIZER_MIN_OSX_VERSION` to 10.10 (from 10.9). TSan does not work on macOS 10.9 and a nice error message is preferable to an "unreferenced symbol" error when loading the TSan runtime. We could try to only bump the deployment target for TSan, but we would have to invest into adding support for this to our CMake build and it does not seem worth it. macOS 10.10 was released in 2014. rdar://31335781
1 parent 0aed648 commit b87fc09

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

compiler-rt/cmake/config-ix.cmake

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -357,14 +357,14 @@ if(APPLE)
357357
elseif(CMAKE_OSX_DEPLOYMENT_TARGET)
358358
set(SANITIZER_MIN_OSX_VERSION ${CMAKE_OSX_DEPLOYMENT_TARGET})
359359
else()
360-
set(SANITIZER_MIN_OSX_VERSION 10.9)
360+
set(SANITIZER_MIN_OSX_VERSION 10.10)
361361
endif()
362362
if(SANITIZER_MIN_OSX_VERSION VERSION_LESS "10.7")
363363
message(FATAL_ERROR "macOS deployment target '${SANITIZER_MIN_OSX_VERSION}' is too old.")
364364
endif()
365-
if(SANITIZER_MIN_OSX_VERSION VERSION_GREATER "10.9")
366-
message(WARNING "macOS deployment target '${SANITIZER_MIN_OSX_VERSION}' is too new, setting to '10.9' instead.")
367-
set(SANITIZER_MIN_OSX_VERSION 10.9)
365+
if(SANITIZER_MIN_OSX_VERSION VERSION_GREATER "10.10")
366+
message(WARNING "macOS deployment target '${SANITIZER_MIN_OSX_VERSION}' is too new, setting to '10.10' instead.")
367+
set(SANITIZER_MIN_OSX_VERSION 10.10)
368368
endif()
369369
endif()
370370

0 commit comments

Comments
 (0)