Skip to content

Commit b98d0b2

Browse files
committed
[InstrProf] Fix macOS profile tests after D156569
In https://reviews.llvm.org/D156569 we changed the format of the IRPGO counter names which broke some macOS tests because the `__profc_` variable names changed. Use `{{_?}}` to allow mangled names to be prefixed with `_` to pass tests. Reviewed By: thakis Differential Revision: https://reviews.llvm.org/D157321
1 parent 7cc6154 commit b98d0b2

File tree

5 files changed

+1069
-1069
lines changed

5 files changed

+1069
-1069
lines changed

clang/test/CodeGen/profile-filter.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ unsigned i;
3737
// EXCLUDE: noprofile
3838
// EXCLUDE: @test1
3939
unsigned test1(void) {
40-
// CHECK: %pgocount = load i64, ptr @__profc_test1
41-
// FUNC: %pgocount = load i64, ptr @__profc_test1
42-
// FILE: %pgocount = load i64, ptr @__profc_test1
43-
// SECTION-NOT: %pgocount = load i64, ptr @__profc_test1
44-
// EXCLUDE-NOT: %pgocount = load i64, ptr @__profc_test1
40+
// CHECK: %pgocount = load i64, ptr @__profc_{{_?}}test1
41+
// FUNC: %pgocount = load i64, ptr @__profc_{{_?}}test1
42+
// FILE: %pgocount = load i64, ptr @__profc_{{_?}}test1
43+
// SECTION-NOT: %pgocount = load i64, ptr @__profc_{{_?}}test1
44+
// EXCLUDE-NOT: %pgocount = load i64, ptr @__profc_{{_?}}test1
4545
return i + 1;
4646
}
4747

@@ -56,10 +56,10 @@ unsigned test1(void) {
5656
// EXCLUDE-NOT: noprofile
5757
// EXCLUDE: @test2
5858
unsigned test2(void) {
59-
// CHECK: %pgocount = load i64, ptr @__profc_test2
60-
// FUNC-NOT: %pgocount = load i64, ptr @__profc_test2
61-
// FILE: %pgocount = load i64, ptr @__profc_test2
62-
// SECTION: %pgocount = load i64, ptr @__profc_test2
63-
// EXCLUDE: %pgocount = load i64, ptr @__profc_test2
59+
// CHECK: %pgocount = load i64, ptr @__profc_{{_?}}test2
60+
// FUNC-NOT: %pgocount = load i64, ptr @__profc_{{_?}}test2
61+
// FILE: %pgocount = load i64, ptr @__profc_{{_?}}test2
62+
// SECTION: %pgocount = load i64, ptr @__profc_{{_?}}test2
63+
// EXCLUDE: %pgocount = load i64, ptr @__profc_{{_?}}test2
6464
return i - 1;
6565
}

clang/test/Profile/gcc-flag-compatibility.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99

1010
// On AIX, -flto used to be required with -fprofile-generate. gcc-flag-compatibility-aix.c is used to do the testing on AIX with -flto
1111
// RUN: %clang %s -c -S -o - -emit-llvm -fprofile-generate | FileCheck -check-prefix=PROFILE-GEN %s
12-
// PROFILE-GEN: @__profc_main = {{(private|internal)}} global [2 x i64] zeroinitializer, section
13-
// PROFILE-GEN: @__profd_main =
12+
// PROFILE-GEN: @__profc_{{_?}}main = {{(private|internal)}} global [2 x i64] zeroinitializer, section
13+
// PROFILE-GEN: @__profd_{{_?}}main =
1414

1515
// Check that -fprofile-generate=/path/to generates /path/to/default.profraw
1616
// RxUN: %clang %s -c -S -o - -emit-llvm -fprofile-generate=/path/to | FileCheck -check-prefixes=PROFILE-GEN,PROFILE-GEN-EQ %s

compiler-rt/test/profile/Inputs/instrprof-value-prof-evict.c

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -61,80 +61,80 @@ int main() {
6161
}
6262

6363
// check site, target patterns
64-
// CHECK: 0, callee_0
64+
// CHECK: 0, {{_?}}callee_0
6565
INDIRECT_CALLSITE(CallSeqTwoTarget_1, 1);
6666

67-
// CHECK-NEXT: 1, callee_0
67+
// CHECK-NEXT: 1, {{_?}}callee_0
6868
INDIRECT_CALLSITE(CallSeqTwoTarget_2, 1);
6969

70-
// CHECK-NEXT: 2, callee_0
70+
// CHECK-NEXT: 2, {{_?}}callee_0
7171
INDIRECT_CALLSITE(CallSeqTwoTarget_3, 1);
7272

73-
// CHECK-NEXT: 3, callee_0
73+
// CHECK-NEXT: 3, {{_?}}callee_0
7474
INDIRECT_CALLSITE(CallSeqTwoTarget_4, 1);
7575

76-
// CHECK-NEXT: 4, callee_0
76+
// CHECK-NEXT: 4, {{_?}}callee_0
7777
INDIRECT_CALLSITE(CallSeqThreeTarget_1, 1);
7878

79-
// CHECK-NEXT: 5, callee_0
79+
// CHECK-NEXT: 5, {{_?}}callee_0
8080
INDIRECT_CALLSITE(CallSeqThreeTarget_2, 1);
8181

82-
// CHECK-NEXT: 6, callee_0
82+
// CHECK-NEXT: 6, {{_?}}callee_0
8383
INDIRECT_CALLSITE(CallSeqThreeTarget_3, 1);
8484

85-
// CHECK-NEXT: 7, callee_0
85+
// CHECK-NEXT: 7, {{_?}}callee_0
8686
INDIRECT_CALLSITE(CallSeqThreeTarget_4, 1);
8787

88-
// CHECK-NEXT: 8, callee_0
89-
// CHECK-NEXT: 8, callee_1
88+
// CHECK-NEXT: 8, {{_?}}callee_0
89+
// CHECK-NEXT: 8, {{_?}}callee_1
9090
INDIRECT_CALLSITE(CallSeqThreeTarget_1, 2);
9191

92-
// CHECK-NEXT: 9, callee_0
93-
// CHECK-NEXT: 9, callee_1
92+
// CHECK-NEXT: 9, {{_?}}callee_0
93+
// CHECK-NEXT: 9, {{_?}}callee_1
9494
INDIRECT_CALLSITE(CallSeqThreeTarget_2, 2);
9595

96-
// CHECK-NEXT: 10, callee_0
97-
// CHECK-NEXT: 10, callee_1
96+
// CHECK-NEXT: 10, {{_?}}callee_0
97+
// CHECK-NEXT: 10, {{_?}}callee_1
9898
INDIRECT_CALLSITE(CallSeqThreeTarget_3, 2);
9999

100-
// CHECK-NEXT: 11, callee_0
101-
// CHECK-NEXT: 11, callee_1
100+
// CHECK-NEXT: 11, {{_?}}callee_0
101+
// CHECK-NEXT: 11, {{_?}}callee_1
102102
INDIRECT_CALLSITE(CallSeqThreeTarget_4, 2);
103103

104-
// CHECK-NEXT: 12, callee_0
104+
// CHECK-NEXT: 12, {{_?}}callee_0
105105
INDIRECT_CALLSITE(CallSeqFourTarget_1, 1);
106106

107-
// CHECK-NEXT: 13, callee_0
107+
// CHECK-NEXT: 13, {{_?}}callee_0
108108
INDIRECT_CALLSITE(CallSeqFourTarget_2, 1);
109109

110-
// CHECK-NEXT: 14, callee_0
110+
// CHECK-NEXT: 14, {{_?}}callee_0
111111
INDIRECT_CALLSITE(CallSeqFourTarget_3, 1);
112112

113-
// CHECK-NEXT: 15, callee_0
114-
// CHECK-NEXT: 15, callee_3
113+
// CHECK-NEXT: 15, {{_?}}callee_0
114+
// CHECK-NEXT: 15, {{_?}}callee_3
115115
INDIRECT_CALLSITE(CallSeqFourTarget_1, 2);
116116

117-
// CHECK-NEXT: 16, callee_0
118-
// CHECK-NEXT: 16, callee_3
117+
// CHECK-NEXT: 16, {{_?}}callee_0
118+
// CHECK-NEXT: 16, {{_?}}callee_3
119119
INDIRECT_CALLSITE(CallSeqFourTarget_2, 2);
120120

121-
// CHECK-NEXT: 17, callee_0
122-
// CHECK-NEXT: 17, callee_3
121+
// CHECK-NEXT: 17, {{_?}}callee_0
122+
// CHECK-NEXT: 17, {{_?}}callee_3
123123
INDIRECT_CALLSITE(CallSeqFourTarget_3, 2);
124124

125-
// CHECK-NEXT: 18, callee_0
126-
// CHECK-NEXT: 18, callee_3
127-
// CHECK-NEXT: 18, callee_2
125+
// CHECK-NEXT: 18, {{_?}}callee_0
126+
// CHECK-NEXT: 18, {{_?}}callee_3
127+
// CHECK-NEXT: 18, {{_?}}callee_2
128128
INDIRECT_CALLSITE(CallSeqFourTarget_1, 3);
129129

130-
// CHECK-NEXT: 19, callee_0
131-
// CHECK-NEXT: 19, callee_3
132-
// CHECK-NEXT: 19, callee_2
130+
// CHECK-NEXT: 19, {{_?}}callee_0
131+
// CHECK-NEXT: 19, {{_?}}callee_3
132+
// CHECK-NEXT: 19, {{_?}}callee_2
133133
INDIRECT_CALLSITE(CallSeqFourTarget_2, 3);
134134

135-
// CHECK-NEXT: 20, callee_0
136-
// CHECK-NEXT: 20, callee_3
137-
// CHECK-NEXT: 20, callee_2
135+
// CHECK-NEXT: 20, {{_?}}callee_0
136+
// CHECK-NEXT: 20, {{_?}}callee_3
137+
// CHECK-NEXT: 20, {{_?}}callee_2
138138
INDIRECT_CALLSITE(CallSeqFourTarget_3, 3);
139139

140140
return 0;

0 commit comments

Comments
 (0)