Skip to content

Commit bb04654

Browse files
committed
Address review comments
1 parent 726cb7d commit bb04654

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

llvm/lib/Target/AArch64/AArch64TargetObjectFile.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ void AArch64_ELFTargetObjectFile::emitPersonalityValueImpl(
4141
// The value is ptrauth_string_discriminator("personality")
4242
constexpr uint16_t Discriminator = 0x7EAD;
4343
TS->emitAuthValue(MCSymbolRefExpr::create(Sym, getContext()), Discriminator,
44-
AArch64PACKey::IA, true, getContext());
44+
AArch64PACKey::IA, /*HasAddressDiversity=*/true);
4545
}
4646

4747
const MCExpr *AArch64_ELFTargetObjectFile::getIndirectSymViaGOTPCRel(

llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ AArch64TargetStreamer::~AArch64TargetStreamer() = default;
3838
void AArch64TargetStreamer::emitAuthValue(const MCExpr *Expr,
3939
uint16_t Discriminator,
4040
AArch64PACKey::ID Key,
41-
bool HasAddressDiversity,
42-
MCContext &Ctx) {
41+
bool HasAddressDiversity) {
4342
Streamer.emitValueImpl(AArch64AuthMCExpr::create(Expr, Discriminator, Key,
44-
HasAddressDiversity, Ctx),
43+
HasAddressDiversity,
44+
Streamer.getContext()),
4545
8);
4646
}
4747

llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ class AArch64TargetStreamer : public MCTargetStreamer {
4242
/// Callback used to emit AUTH expressions (e.g. signed
4343
/// personality function pointer).
4444
void emitAuthValue(const MCExpr *Expr, uint16_t Discriminator,
45-
AArch64PACKey::ID Key, bool HasAddressDiversity,
46-
MCContext &Ctx);
45+
AArch64PACKey::ID Key, bool HasAddressDiversity);
4746

4847
/// Callback used to implement the .inst directive.
4948
virtual void emitInst(uint32_t Inst);

0 commit comments

Comments
 (0)