Skip to content

Commit bbdca53

Browse files
committed
[KnownBitsTest] Add optimality tests to some optimal impls; NFC
Adding optimality test to `add`, `sub`, `avgCeilU` and `avgFloorU`
1 parent 8518178 commit bbdca53

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

llvm/unittests/Support/KnownBitsTest.cpp

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -305,15 +305,13 @@ TEST(KnownBitsTest, BinaryExhaustive) {
305305
[](const KnownBits &Known1, const KnownBits &Known2) {
306306
return KnownBits::add(Known1, Known2);
307307
},
308-
[](const APInt &N1, const APInt &N2) { return N1 + N2; },
309-
/*CheckOptimality=*/false);
308+
[](const APInt &N1, const APInt &N2) { return N1 + N2; });
310309
testBinaryOpExhaustive(
311310
"sub",
312311
[](const KnownBits &Known1, const KnownBits &Known2) {
313312
return KnownBits::sub(Known1, Known2);
314313
},
315-
[](const APInt &N1, const APInt &N2) { return N1 - N2; },
316-
/*CheckOptimality=*/false);
314+
[](const APInt &N1, const APInt &N2) { return N1 - N2; });
317315
testBinaryOpExhaustive("umax", KnownBits::umax, APIntOps::umax);
318316
testBinaryOpExhaustive("umin", KnownBits::umin, APIntOps::umin);
319317
testBinaryOpExhaustive("smax", KnownBits::smax, APIntOps::smax);
@@ -524,16 +522,15 @@ TEST(KnownBitsTest, BinaryExhaustive) {
524522
/*CheckOptimality=*/false);
525523

526524
testBinaryOpExhaustive("avgFloorS", KnownBits::avgFloorS, APIntOps::avgFloorS,
527-
false);
525+
/*CheckOptimality=*/false);
528526

529-
testBinaryOpExhaustive("avgFloorU", KnownBits::avgFloorU, APIntOps::avgFloorU,
530-
false);
527+
testBinaryOpExhaustive("avgFloorU", KnownBits::avgFloorU,
528+
APIntOps::avgFloorU);
531529

532-
testBinaryOpExhaustive("avgCeilU", KnownBits::avgCeilU, APIntOps::avgCeilU,
533-
false);
530+
testBinaryOpExhaustive("avgCeilU", KnownBits::avgCeilU, APIntOps::avgCeilU);
534531

535532
testBinaryOpExhaustive("avgCeilS", KnownBits::avgCeilS, APIntOps::avgCeilS,
536-
false);
533+
/*CheckOptimality=*/false);
537534
}
538535

539536
TEST(KnownBitsTest, UnaryExhaustive) {

0 commit comments

Comments
 (0)