Skip to content

Commit bc368e4

Browse files
committed
[lldb][test] TestConstStaticIntegralMember.py: skip dsym variant for older compiler versions
The existing XFAIL was being ignored because of the `expectedFailureDarwin` causing failures on the matrix macOS bot: ``` ====================================================================== FAIL: test_inline_static_members_dwarf5_dsym (TestConstStaticIntegralMember.TestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1769, in test_method return attrvalue(self) File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py", line 151, in test_inline_static_members_dwarf5 self.check_inline_static_members("-gdwarf-5") File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py", line 129, in check_inline_static_members self.check_global_var("A::int_val", "const int", "1") File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py", line 118, in check_global_var self.assertGreaterEqual(len(var_list), 1) AssertionError: 0 not greater than or equal to 1 Config=x86_64-/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/clang_1501_build/bin/clang ====================================================================== FAIL: test_shadowed_static_inline_members_dwarf5_dsym (TestConstStaticIntegralMember.TestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1769, in test_method return attrvalue(self) File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py", line 205, in test_shadowed_static_inline_members_dwarf5 self.check_shadowed_static_inline_members("-gdwarf-5") File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py", line 192, in check_shadowed_static_inline_members self.check_global_var("ns::Foo::mem", "const int", "10") File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py", line 118, in check_global_var self.assertGreaterEqual(len(var_list), 1) AssertionError: 0 not greater than or equal to 1 Config=x86_64-/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/clang_1501_build/bin/clang ---------------------------------------------------------------------- ```
1 parent 89aaf2c commit bc368e4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ def check_inline_static_members(self, flags):
146146
@skipIfWindows
147147
# On linux this passes due to the manual index
148148
@expectedFailureDarwin(debug_info=no_match(["dsym"]))
149-
@expectedFailureAll(debug_info=["dsym"], compiler=["clang"], compiler_version=["<", "19.0"])
149+
@skipIf(debug_info=["dsym"], compiler=["clang"], compiler_version=["<", "19.0"])
150150
def test_inline_static_members_dwarf5(self):
151151
self.check_inline_static_members("-gdwarf-5")
152152

@@ -200,7 +200,7 @@ def check_shadowed_static_inline_members(self, flags):
200200
@skipIfWindows
201201
# On linux this passes due to the manual index
202202
@expectedFailureDarwin(debug_info=no_match(["dsym"]))
203-
@expectedFailureAll(debug_info=["dsym"], compiler=["clang"], compiler_version=["<", "19.0"])
203+
@skipIf(debug_info=["dsym"], compiler=["clang"], compiler_version=["<", "19.0"])
204204
def test_shadowed_static_inline_members_dwarf5(self):
205205
self.check_shadowed_static_inline_members("-gdwarf-5")
206206

0 commit comments

Comments
 (0)