[MC] Simplify isSymbolRefDifferenceFullyResolvedImpl overloads. NFC

MaskRay · MaskRay · commit bc6d92552843 · 2024-06-29T16:10:33.000-07:00
The base implementation is simple. Just inline it.
diff --git a/llvm/lib/MC/ELFObjectWriter.cpp b/llvm/lib/MC/ELFObjectWriter.cpp
@@ -1521,8 +1521,7 @@ bool ELFObjectWriter::isSymbolRefDifferenceFullyResolvedImpl(
         SymA.getType() == ELF::STT_GNU_IFUNC)
       return false;
   }
-  return MCObjectWriter::isSymbolRefDifferenceFullyResolvedImpl(Asm, SymA, FB,
-                                                                InSet, IsPCRel);
+  return &SymA.getSection() == FB.getParent();
 }
 
 std::unique_ptr<MCObjectWriter>
diff --git a/llvm/lib/MC/WinCOFFObjectWriter.cpp b/llvm/lib/MC/WinCOFFObjectWriter.cpp
@@ -1204,8 +1204,7 @@ bool WinCOFFObjectWriter::isSymbolRefDifferenceFullyResolvedImpl(
   uint16_t Type = cast<MCSymbolCOFF>(SymA).getType();
   if ((Type >> COFF::SCT_COMPLEX_TYPE_SHIFT) == COFF::IMAGE_SYM_DTYPE_FUNCTION)
     return false;
-  return MCObjectWriter::isSymbolRefDifferenceFullyResolvedImpl(Asm, SymA, FB,
-                                                                InSet, IsPCRel);
+  return &SymA.getSection() == FB.getParent();
 }
 
 void WinCOFFObjectWriter::executePostLayoutBinding(MCAssembler &Asm,

Original file line number	Diff line number	Diff line change
`@@ -1521,8 +1521,7 @@ bool ELFObjectWriter::isSymbolRefDifferenceFullyResolvedImpl(`
`1521`	`1521`	`SymA.getType() == ELF::STT_GNU_IFUNC)`
`1522`	`1522`	`return false;`
`1523`	`1523`	`}`
`1524`		`- return MCObjectWriter::isSymbolRefDifferenceFullyResolvedImpl(Asm, SymA, FB,`
`1525`		`- InSet, IsPCRel);`
	`1524`	`+ return &SymA.getSection() == FB.getParent();`
`1526`	`1525`	`}`
`1527`	`1526`
`1528`	`1527`	`std::unique_ptr<MCObjectWriter>`
Original file line number	Diff line number	Diff line change
`@@ -1204,8 +1204,7 @@ bool WinCOFFObjectWriter::isSymbolRefDifferenceFullyResolvedImpl(`
`1204`	`1204`	`uint16_t Type = cast<MCSymbolCOFF>(SymA).getType();`
`1205`	`1205`	`if ((Type >> COFF::SCT_COMPLEX_TYPE_SHIFT) == COFF::IMAGE_SYM_DTYPE_FUNCTION)`
`1206`	`1206`	`return false;`
`1207`		`- return MCObjectWriter::isSymbolRefDifferenceFullyResolvedImpl(Asm, SymA, FB,`
`1208`		`- InSet, IsPCRel);`
	`1207`	`+ return &SymA.getSection() == FB.getParent();`
`1209`	`1208`	`}`
`1210`	`1209`
`1211`	`1210`	`void WinCOFFObjectWriter::executePostLayoutBinding(MCAssembler &Asm,`