Skip to content

Commit bdcbe67

Browse files
authored
[llvm] remove llvm:: qualification from appendLoopsToWorklist extern template instantiations (#143555)
## Purpose Fix a build break introduced by #143413. This was a copy+paste error where the `llvm::` qualifier was left on the template instantiation declarations that were added. This causes a compile error with the version of the compiler used by the mlir-nvidia-gcc7 build. ``` /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/Transforms/Utils/LoopUtils.h:539:72: error: explicit qualification in declaration of ‘void llvm::appendLoopsToWorklist(llvm::ArrayRef<llvm::Loop*>&, llvm::SmallPriorityWorklist<llvm::Loop*, 4>&)’ ArrayRef<Loop *> &Loops, SmallPriorityWorklist<Loop *, 4> &Worklist); ^ /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/Transforms/Utils/LoopUtils.h:543:79: error: explicit qualification in declaration of ‘void llvm::appendLoopsToWorklist(llvm::Loop&, llvm::SmallPriorityWorklist<llvm::Loop*, 4>&)’ SmallPriorityWorklist<Loop *, 4> &Worklist); ```
1 parent 1c3320c commit bdcbe67

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

llvm/include/llvm/Transforms/Utils/LoopUtils.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -535,12 +535,12 @@ void appendReversedLoopsToWorklist(RangeT &&,
535535
SmallPriorityWorklist<Loop *, 4> &);
536536

537537
extern template LLVM_TEMPLATE_ABI void
538-
llvm::appendLoopsToWorklist<ArrayRef<Loop *> &>(
538+
appendLoopsToWorklist<ArrayRef<Loop *> &>(
539539
ArrayRef<Loop *> &Loops, SmallPriorityWorklist<Loop *, 4> &Worklist);
540540

541541
extern template LLVM_TEMPLATE_ABI void
542-
llvm::appendLoopsToWorklist<Loop &>(Loop &L,
543-
SmallPriorityWorklist<Loop *, 4> &Worklist);
542+
appendLoopsToWorklist<Loop &>(Loop &L,
543+
SmallPriorityWorklist<Loop *, 4> &Worklist);
544544

545545
/// Utility that implements appending of loops onto a worklist given LoopInfo.
546546
/// Calls the templated utility taking a Range of loops, handing it the Loops

0 commit comments

Comments
 (0)