Address comment about using std::forward<_Compare>() for consistency in __set_intersection() base overload.

ichaer · ichaer · commit be6c5c848d56 · 2024-04-27T11:22:37.000+01:00
diff --git a/libcxx/include/__algorithm/set_intersection.h b/libcxx/include/__algorithm/set_intersection.h
@@ -162,7 +162,7 @@ __set_intersection(
       std::move(__first2),
       std::move(__last2),
       std::move(__result),
-      __comp,
+       std::forward<_Compare>(__comp),
       typename std::_IterOps<_AlgPolicy>::template __iterator_category<_InIter1>(),
       typename std::_IterOps<_AlgPolicy>::template __iterator_category<_InIter2>());
 }

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ __set_intersection(`
`162`	`162`	`std::move(__first2),`
`163`	`163`	`std::move(__last2),`
`164`	`164`	`std::move(__result),`
`165`		`- __comp,`
	`165`	`+ std::forward<_Compare>(__comp),`
`166`	`166`	`typename std::_IterOps<_AlgPolicy>::template __iterator_category<_InIter1>(),`
`167`	`167`	`typename std::_IterOps<_AlgPolicy>::template __iterator_category<_InIter2>());`
`168`	`168`	`}`