Fixups

Author: MacDue

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

@@ -975,19 +975,20 @@ def LLVM_TargetFeaturesAttr : LLVM_Attr<"TargetFeatures", "target_features">
     bool contains(::llvm::StringRef feature) const;
 
     bool nullOrEmpty() const {
-      // Checks if this attribute is fasly, or the features are empty.
+      // Checks if this attribute is null, or the features are empty.
       return !bool(*this) || getFeatures().empty();
     }
 
     /// Returns the list of features as an LLVM-compatible string.
     std::string getFeaturesString() const;
 
     /// Finds the target features on the parent FunctionOpInterface.
-    /// Note: This assumes the attribute is called "target_features".
+    /// Note: This assumes the attribute name matches the return value of
+    /// `getAttributeName()`.
     static TargetFeaturesAttr featuresAt(Operation* op);
 
     /// Canonical name for this attribute within MLIR.
-    static constexpr StringLiteral attributeName() {
+    static constexpr StringLiteral getAttributeName() {
       return StringLiteral("target_features");
     }
   }];

mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp

@@ -246,5 +246,5 @@ TargetFeaturesAttr TargetFeaturesAttr::featuresAt(Operation *op) {
   if (!parentFunction)
     return {};
   return parentFunction.getOperation()->getAttrOfType<TargetFeaturesAttr>(
-      attributeName());
+      getAttributeName());
 }