Skip to content

Commit bf02dfc

Browse files
authored
[llvm][ADT] Some AddressRanges.h improvements (#132847)
- Rename parameter to adhere to the project's parameter naming convention. - Remove redundant template argument. - Remove redundant name-qualification. - Change non-explicit conversion operator to an explicit one to avoid surprising implicit conversions.
1 parent 783a846 commit bf02dfc

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

llvm/include/llvm/ADT/AddressRanges.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,12 +83,12 @@ template <typename T> class AddressRangesBase {
8383
typename Collection::const_iterator begin() const { return Ranges.begin(); }
8484
typename Collection::const_iterator end() const { return Ranges.end(); }
8585

86-
const T &operator[](size_t i) const {
87-
assert(i < Ranges.size());
88-
return Ranges[i];
86+
const T &operator[](size_t I) const {
87+
assert(I < Ranges.size());
88+
return Ranges[I];
8989
}
9090

91-
bool operator==(const AddressRangesBase<T> &RHS) const {
91+
bool operator==(const AddressRangesBase &RHS) const {
9292
return Ranges == RHS.Ranges;
9393
}
9494

@@ -124,7 +124,7 @@ class AddressRanges : public AddressRangesBase<AddressRange> {
124124
if (Range.empty())
125125
return Ranges.end();
126126

127-
auto It = llvm::upper_bound(Ranges, Range);
127+
auto It = upper_bound(Ranges, Range);
128128
auto It2 = It;
129129
while (It2 != Ranges.end() && It2->start() <= Range.end())
130130
++It2;
@@ -144,7 +144,7 @@ class AddressRanges : public AddressRangesBase<AddressRange> {
144144

145145
class AddressRangeValuePair {
146146
public:
147-
operator AddressRange() const { return Range; }
147+
explicit operator AddressRange() const { return Range; }
148148

149149
AddressRange Range;
150150
int64_t Value = 0;

0 commit comments

Comments
 (0)