Skip to content

Commit bf61891

Browse files
committed
[libc++abi] Fix incorrect XFAILs for mis-aligned _Unwind_Exception on Apple
The problem mentioned in the XFAILs has been resolved in macosx10.15, so the test is now XPASSing on that platform. rdar://63640184
1 parent febeaf9 commit bf61891

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

libcxxabi/test/test_exception_address_alignment.pass.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,14 @@
99
// UNSUPPORTED: no-exceptions
1010
// UNSUPPORTED: c++03
1111

12-
// The system unwind.h on OS X provides an incorrectly aligned _Unwind_Exception
13-
// type. That causes these tests to fail. This XFAIL is my best attempt at
14-
// working around this failure.
15-
// XFAIL: darwin && libcxxabi-has-system-unwinder
12+
// The system unwind.h on older OSX versions provided an incorrectly aligned
13+
// _Unwind_Exception type. That causes these tests to fail on those platforms.
14+
// XFAIL: macosx10.14 && libcxxabi-has-system-unwinder
15+
// XFAIL: macosx10.13 && libcxxabi-has-system-unwinder
16+
// XFAIL: macosx10.12 && libcxxabi-has-system-unwinder
17+
// XFAIL: macosx10.11 && libcxxabi-has-system-unwinder
18+
// XFAIL: macosx10.10 && libcxxabi-has-system-unwinder
19+
// XFAIL: macosx10.9 && libcxxabi-has-system-unwinder
1620

1721
// Test that the address of the exception object is properly aligned as required
1822
// by the relevant ABI

0 commit comments

Comments
 (0)