Skip to content

Commit bf7f8d6

Browse files
committed
[NFC][RFC][TableGen] Improve the comment about variable len encoder
When, for example, using "ascend" operator, I was wondering whether the bit order of the dag argument will be reversed in ascend order as well. This patch clarifies it. Reviewed By: myhsu Differential Revision: https://reviews.llvm.org/D119653
1 parent 5fd28e4 commit bf7f8d6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

llvm/include/llvm/Target/Target.td

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -758,15 +758,15 @@ def variable_ops;
758758

759759
/// variable-length instruction encoding utilities.
760760
/// The `ascend` operator should be used like this:
761-
/// (ascend 0b0000, 0b1111)
761+
/// (ascend 0b0010, 0b1101)
762762
/// Which represent a seqence of encoding fragments placing from LSB to MSB.
763-
/// Thus, in this case the final encoding will be 0b11110000.
763+
/// Thus, in this case the final encoding will be 0b1101_0010.
764764
/// The arguments for `ascend` can either be `bits` or another DAG.
765765
def ascend;
766766
/// In addition, we can use `descend` to describe an encoding that places
767767
/// its arguments (i.e. encoding fragments) from MSB to LSB. For instance:
768-
/// (descend 0b0000, 0b1111)
769-
/// This results in an encoding of 0b00001111.
768+
/// (descend 0b0010, 0b1101)
769+
/// This results in an encoding of 0b0010_1101.
770770
def descend;
771771
/// The `operand` operator should be used like this:
772772
/// (operand "$src", 4)

0 commit comments

Comments
 (0)