Skip to content

Commit bf8683a

Browse files
committed
[libc++] [docs] Mark LWG3055 as complete. Use string_view instead of string in path::operator+=(ECharT).
The issue didn't change the behaviour which is tested in libcxx/test/std/input.output/filesystems/class.path/path.member/path.concat.pass.cpp. The change to use string_view instead of string is not strictly necessary. <filesystem> was added in commit 998a5c8 (Implement <filesystem>). Reviewed By: #libc, ldionne Differential Revision: https://reviews.llvm.org/D92731
1 parent 32825e8 commit bf8683a

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

libcxx/docs/Cxx2aStatusIssuesStatus.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@
143143
"`3182 <https://wg21.link/LWG3182>`__","Specification of ``Same``\ could be clearer","Kona","",""
144144
"","","","",""
145145
"`2899 <https://wg21.link/LWG2899>`__","``is_(nothrow_)move_constructible``\ and ``tuple``\ , ``optional``\ and ``unique_ptr``\ ","Cologne","",""
146-
"`3055 <https://wg21.link/LWG3055>`__","``path::operator+=(*single-character*)``\ misspecified","Cologne","",""
146+
"`3055 <https://wg21.link/LWG3055>`__","``path::operator+=(*single-character*)``\ misspecified","Cologne","|Complete|","7.0"
147147
"`3158 <https://wg21.link/LWG3158>`__","``tuple(allocator_arg_t, const Alloc&)``\ should be conditionally explicit","Cologne","",""
148148
"`3169 <https://wg21.link/LWG3169>`__","``ranges``\ permutation generators discard useful information","Cologne","",""
149149
"`3183 <https://wg21.link/LWG3183>`__","Normative permission to specialize Ranges variable templates","Cologne","",""

libcxx/include/filesystem

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -940,9 +940,8 @@ public:
940940
template <class _ECharT>
941941
typename enable_if<__can_convert_char<_ECharT>::value, path&>::type
942942
operator+=(_ECharT __x) {
943-
basic_string<_ECharT> __tmp;
944-
__tmp += __x;
945-
_PathCVT<_ECharT>::__append_source(__pn_, __tmp);
943+
_PathCVT<_ECharT>::__append_source(__pn_,
944+
basic_string_view<_ECharT>(&__x, 1));
946945
return *this;
947946
}
948947

0 commit comments

Comments
 (0)