Make isSafeToSpeculativelyExecute assertion a isSpeculatable check

Author: lukel97

llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp

@@ -1401,12 +1401,10 @@ static Instruction *factorizeMinMaxTree(IntrinsicInst *II) {
 /// try to shuffle after the intrinsic.
 Instruction *
 InstCombinerImpl::foldShuffledIntrinsicOperands(IntrinsicInst *II) {
-  if (!isTriviallyVectorizable(II->getIntrinsicID()))
+  if (!isTriviallyVectorizable(II->getIntrinsicID()) ||
+      !II->getCalledFunction()->isSpeculatable())
     return nullptr;
 
-  assert(isSafeToSpeculativelyExecute(II) &&
-         "Trivially vectorizable but not safe to speculatively execute?");
-
   // fabs is canonicalized to fabs (shuffle ...) in foldShuffleOfUnaryOps, so
   // avoid undoing it.
   if (match(II, m_FAbs(m_Value())))