Skip to content

Commit c018ae9

Browse files
[NewPM] Remove Reg2Mem Legacy Pass (#73404)
This pass isn't used anywhere upstream and thus has no test coverage. For these reasons it should be removed.
1 parent 6b708cc commit c018ae9

File tree

5 files changed

+0
-47
lines changed

5 files changed

+0
-47
lines changed

llvm/include/llvm/InitializePasses.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,6 @@ void initializeRegAllocFastPass(PassRegistry&);
260260
void initializeRegAllocPriorityAdvisorAnalysisPass(PassRegistry &);
261261
void initializeRegAllocScoringPass(PassRegistry &);
262262
void initializeRegBankSelectPass(PassRegistry&);
263-
void initializeRegToMemLegacyPass(PassRegistry&);
264263
void initializeRegUsageInfoCollectorPass(PassRegistry&);
265264
void initializeRegUsageInfoPropagationPass(PassRegistry&);
266265
void initializeRegionInfoPassPass(PassRegistry&);

llvm/include/llvm/LinkAllPasses.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ namespace {
9797
(void) llvm::createNaryReassociatePass();
9898
(void) llvm::createObjCARCContractPass();
9999
(void) llvm::createPromoteMemoryToRegisterPass();
100-
(void) llvm::createDemoteRegisterToMemoryPass();
101100
(void)llvm::createPostDomOnlyPrinterWrapperPassPass();
102101
(void)llvm::createPostDomPrinterWrapperPassPass();
103102
(void)llvm::createPostDomOnlyViewerWrapperPassPass();

llvm/include/llvm/Transforms/Scalar.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -74,15 +74,6 @@ Pass *createLoopUnrollPass(int OptLevel = 2, bool OnlyWhenForced = false,
7474
//
7575
Pass *createLoopRotatePass(int MaxHeaderSize = -1, bool PrepareForLTO = false);
7676

77-
//===----------------------------------------------------------------------===//
78-
//
79-
// DemoteRegisterToMemoryPass - This pass is used to demote registers to memory
80-
// references. In basically undoes the PromoteMemoryToRegister pass to make cfg
81-
// hacking easier.
82-
//
83-
FunctionPass *createDemoteRegisterToMemoryPass();
84-
extern char &DemoteRegisterToMemoryID;
85-
8677
//===----------------------------------------------------------------------===//
8778
//
8879
// Reassociate - This pass reassociates commutative expressions in an order that

llvm/lib/Transforms/Scalar/Reg2Mem.cpp

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525
#include "llvm/IR/InstIterator.h"
2626
#include "llvm/IR/Instructions.h"
2727
#include "llvm/IR/PassManager.h"
28-
#include "llvm/InitializePasses.h"
29-
#include "llvm/Pass.h"
3028
#include "llvm/Transforms/Scalar.h"
3129
#include "llvm/Transforms/Utils.h"
3230
#include "llvm/Transforms/Utils/BasicBlockUtils.h"
@@ -107,36 +105,3 @@ PreservedAnalyses RegToMemPass::run(Function &F, FunctionAnalysisManager &AM) {
107105
PA.preserve<LoopAnalysis>();
108106
return PA;
109107
}
110-
111-
namespace {
112-
struct RegToMemLegacy : public FunctionPass {
113-
static char ID; // Pass identification, replacement for typeid
114-
RegToMemLegacy() : FunctionPass(ID) {
115-
initializeRegToMemLegacyPass(*PassRegistry::getPassRegistry());
116-
}
117-
118-
void getAnalysisUsage(AnalysisUsage &AU) const override {
119-
AU.addRequiredID(BreakCriticalEdgesID);
120-
AU.addPreservedID(BreakCriticalEdgesID);
121-
}
122-
123-
bool runOnFunction(Function &F) override {
124-
if (F.isDeclaration() || skipFunction(F))
125-
return false;
126-
return runPass(F);
127-
}
128-
};
129-
} // namespace
130-
131-
char RegToMemLegacy::ID = 0;
132-
INITIALIZE_PASS_BEGIN(RegToMemLegacy, "reg2mem",
133-
"Demote all values to stack slots", false, false)
134-
INITIALIZE_PASS_DEPENDENCY(BreakCriticalEdges)
135-
INITIALIZE_PASS_END(RegToMemLegacy, "reg2mem",
136-
"Demote all values to stack slots", false, false)
137-
138-
// createDemoteRegisterToMemory - Provide an entry point to create this pass.
139-
char &llvm::DemoteRegisterToMemoryID = RegToMemLegacy::ID;
140-
FunctionPass *llvm::createDemoteRegisterToMemoryPass() {
141-
return new RegToMemLegacy();
142-
}

llvm/lib/Transforms/Scalar/Scalar.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ void llvm::initializeScalarOpts(PassRegistry &Registry) {
3939
initializePartiallyInlineLibCallsLegacyPassPass(Registry);
4040
initializeReassociateLegacyPassPass(Registry);
4141
initializeRedundantDbgInstEliminationPass(Registry);
42-
initializeRegToMemLegacyPass(Registry);
4342
initializeScalarizeMaskedMemIntrinLegacyPassPass(Registry);
4443
initializeSROALegacyPassPass(Registry);
4544
initializeCFGSimplifyPassPass(Registry);

0 commit comments

Comments
 (0)