Skip to content

Commit c0d7f0c

Browse files
committed
[DAGCombine] fold (sext (sext_inreg x)) -> (sext (trunc x))
This fixes a regression introduced by D127115 in test/CodeGen/PowerPC/store-forward-be64.ll Reviewed By: RKSimon Differential Revision: https://reviews.llvm.org/D140993
1 parent 263d2fc commit c0d7f0c

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12359,6 +12359,16 @@ SDValue DAGCombiner::visitSIGN_EXTEND(SDNode *N) {
1235912359
if (N0.getOpcode() == ISD::SIGN_EXTEND || N0.getOpcode() == ISD::ANY_EXTEND)
1236012360
return DAG.getNode(ISD::SIGN_EXTEND, DL, VT, N0.getOperand(0));
1236112361

12362+
// fold (sext (sext_inreg x)) -> (sext (trunc x))
12363+
if (N0.getOpcode() == ISD::SIGN_EXTEND_INREG) {
12364+
SDValue N00 = N0.getOperand(0);
12365+
EVT ExtVT = cast<VTSDNode>(N0->getOperand(1))->getVT();
12366+
if (N00.getOpcode() == ISD::TRUNCATE && (!LegalOperations || TLI.isTypeLegal(ExtVT))) {
12367+
SDValue T = DAG.getNode(ISD::TRUNCATE, DL, ExtVT, N00.getOperand(0));
12368+
return DAG.getNode(ISD::SIGN_EXTEND, DL, VT, T);
12369+
}
12370+
}
12371+
1236212372
if (N0.getOpcode() == ISD::TRUNCATE) {
1236312373
// fold (sext (truncate (load x))) -> (sext (smaller load x))
1236412374
// fold (sext (truncate (srl (load x), c))) -> (sext (smaller load (x+c/n)))

llvm/test/CodeGen/X86/sdiv_fix.ll

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,8 @@ define i16 @func(i16 %x, i16 %y) nounwind {
6565
define i16 @func2(i8 %x, i8 %y) nounwind {
6666
; X64-LABEL: func2:
6767
; X64: # %bb.0:
68-
; X64-NEXT: movsbl %dil, %eax
69-
; X64-NEXT: movsbl %sil, %ecx
70-
; X64-NEXT: movswl %cx, %esi
71-
; X64-NEXT: movswl %ax, %ecx
68+
; X64-NEXT: movsbl %sil, %esi
69+
; X64-NEXT: movsbl %dil, %ecx
7270
; X64-NEXT: shll $14, %ecx
7371
; X64-NEXT: movl %ecx, %eax
7472
; X64-NEXT: cltd

llvm/test/CodeGen/X86/sdiv_fix_sat.ll

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,8 @@ define i16 @func2(i8 %x, i8 %y) nounwind {
8181
;
8282
; X64-LABEL: func2:
8383
; X64: # %bb.0:
84-
; X64-NEXT: movsbl %dil, %eax
85-
; X64-NEXT: movsbl %sil, %ecx
86-
; X64-NEXT: movswl %cx, %esi
87-
; X64-NEXT: movswl %ax, %ecx
84+
; X64-NEXT: movsbl %sil, %esi
85+
; X64-NEXT: movsbl %dil, %ecx
8886
; X64-NEXT: shll $14, %ecx
8987
; X64-NEXT: movl %ecx, %eax
9088
; X64-NEXT: cltd

0 commit comments

Comments
 (0)