allow bool overload, add bool test

Author: kmpeng

clang/lib/Headers/hlsl/hlsl_compat_overloads.h

@@ -286,11 +286,8 @@ _DXC_COMPAT_TERNARY_INTEGER_OVERLOADS(lerp)
 
 template <typename T>
 constexpr __detail::enable_if_t<__detail::is_arithmetic<T>::Value &&
-                                    (__detail::is_same<double, T>::value ||
-                                     __detail::is_same<int, T>::value ||
-                                     __detail::is_same<uint, T>::value ||
-                                     __detail::is_same<int64_t, T>::value ||
-                                     __detail::is_same<uint64_t, T>::value),
+                                    !__detail::is_same<half, T>::value &&
+                                    !__detail::is_same<float, T>::value,
                                 vector<T, 4>>
 lit(T NDotL, T NDotH, T M) {
   return lit((float)NDotL, (float)NDotH, (float)M);

clang/test/CodeGenHLSL/builtins/lit-overloads.hlsl

@@ -91,3 +91,21 @@ int64_t4 test_lit_int64_t(int64_t NDotL, int64_t NDotH, int64_t M) { return lit(
 // CHECK: %conv3.i = fptoui <4 x float> %{{.*}} to <4 x i64>
 // CHECK: ret <4 x i64> %conv3.i
 uint64_t4 test_lit_uint64_t(uint64_t NDotL, uint64_t NDotH, uint64_t M) { return lit(NDotL, NDotH, M); }
+
+// CHECK-LABEL: test_lit_bool
+// CHECK: %conv.i = uitofp i1 %{{.*}} to float
+// CHECK: %conv4.i = uitofp i1 %{{.*}} to float
+// CHECK: %conv6.i = uitofp i1 %{{.*}} to float
+// CHECK: %cmp.i = fcmp reassoc nnan ninf nsz arcp afn olt float %{{.*}}, 0.000000e+00
+// CHECK: %hlsl.select.i = select reassoc nnan ninf nsz arcp afn i1 %{{.*}}, float 0.000000e+00, float %{{.*}}
+// CHECK: %vecinit.i = insertelement <4 x float> <float 1.000000e+00, float poison, float poison, float poison>, float %{{.*}}, i32 1
+// CHECK: %cmp4.i = fcmp reassoc nnan ninf nsz arcp afn olt float %{{.*}}, 0.000000e+00
+// CHECK: %hlsl.or.i = or i1 %{{.*}}, %cmp4.i
+// CHECK: %elt.log.i = call reassoc nnan ninf nsz arcp afn float @llvm.log.f32(float %{{.*}})
+// CHECK: %mul.i = fmul reassoc nnan ninf nsz arcp afn float %elt.log.i, %{{.*}}
+// CHECK: %elt.exp.i = call reassoc nnan ninf nsz arcp afn float @llvm.exp.f32(float %mul.i)
+// CHECK: %hlsl.select7.i = select reassoc nnan ninf nsz arcp afn i1 %{{.*}}, float 0.000000e+00, float %{{.*}}
+// CHECK: %vecins.i = insertelement <4 x float> %{{.*}}, float %hlsl.select7.i, i32 2
+// CHECK: %tobool.i = fcmp reassoc nnan ninf nsz arcp afn une <4 x float> %{{.*}}, zeroinitializer
+// CHECK: ret <4 x i1> %tobool.i
+bool4 test_lit_bool(bool NDotL, bool NDotH, bool M) { return lit(NDotL, NDotH, M); }