address review comments

Author: Dinistro

mlir/include/mlir/IR/Builders.h

@@ -567,7 +567,7 @@ class OpBuilder : public Builder {
   }
 
   /// Attempts to fold the given operation and places new results within
-  /// 'results'. Returns success if the operation was folded, failure otherwise.
+  /// `results`. Returns success if the operation was folded, failure otherwise.
   /// If the fold was in-place, `results` will not be filled.
   /// Note: This function does not erase the operation on a successful fold.
   LogicalResult tryFold(Operation *op, SmallVectorImpl<Value> &results);

mlir/lib/IR/Builders.cpp

@@ -478,7 +478,7 @@ Operation *OpBuilder::create(Location loc, StringAttr opName,
 
 LogicalResult OpBuilder::tryFold(Operation *op,
                                  SmallVectorImpl<Value> &results) {
-  assert(results.empty());
+  assert(results.empty() && "expected empty results");
   ResultRange opResults = op->getResults();
 
   results.reserve(opResults.size());

mlir/test/Transforms/test-legalizer.mlir

@@ -433,7 +433,7 @@ func.func @use_of_replaced_bbarg(%arg0: i64) {
 // CHECK-LABEL: @fold_legalization
 func.func @fold_legalization() -> i32 {
   // CHECK: op_in_place_self_fold
-  // CHECK-SAME: folded = true
+  // CHECK-SAME: folded
   %1 = "test.op_in_place_self_fold"() : () -> (i32)
   "test.return"(%1) : (i32) -> ()
 }

mlir/test/lib/Dialect/Test/TestOps.td

@@ -1352,7 +1352,7 @@ def TestOpInPlaceFold : TEST_Op<"op_in_place_fold"> {
 }
 
 def TestOpInPlaceSelfFold : TEST_Op<"op_in_place_self_fold"> {
-  let arguments = (ins OptionalAttr<BoolAttr>:$folded);
+  let arguments = (ins UnitAttr:$folded);
   let results = (outs I32);
   let hasFolder = 1;
 }

mlir/test/lib/Dialect/Test/TestPatterns.cpp

@@ -1170,9 +1170,7 @@ struct TestLegalizePatternDriver
 
     // Create a dynamically legal rule that can only be legalized by folding it.
     target.addDynamicallyLegalOp<TestOpInPlaceSelfFold>(
-        [](TestOpInPlaceSelfFold op) {
-          return op.getProperties().folded != nullptr;
-        });
+        [](TestOpInPlaceSelfFold op) { return op.getFolded(); });
 
     // Handle a partial conversion.
     if (mode == ConversionMode::Partial) {