Skip to content

Commit c6847ec

Browse files
committed
address more review comments
1 parent ff47980 commit c6847ec

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

mlir/lib/Dialect/SCF/TransformOps/SCFTransformOps.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -440,10 +440,8 @@ transform::LoopFuseSiblingOp::apply(transform::TransformRewriter &rewriter,
440440
<< "source handle (got " << llvm::range_size(sourceOps) << ")";
441441
}
442442

443-
LoopLikeOpInterface target =
444-
dyn_cast<LoopLikeOpInterface>(*targetOps.begin());
445-
LoopLikeOpInterface source =
446-
dyn_cast<LoopLikeOpInterface>(*sourceOps.begin());
443+
auto target = dyn_cast<LoopLikeOpInterface>(*targetOps.begin());
444+
auto source = dyn_cast<LoopLikeOpInterface>(*sourceOps.begin());
447445
if (!target || !source)
448446
return emitSilenceableFailure(target->getLoc())
449447
<< "target or source is not a loop op";

mlir/lib/Dialect/SCF/Utils/Utils.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1220,6 +1220,7 @@ scf::ForOp mlir::fuseIndependentSiblingForLoops(scf::ForOp target,
12201220
// interface methods.
12211221
scf::ParallelOp mlir::fuseIndependentSiblingParallelLoops(
12221222
scf::ParallelOp target, scf::ParallelOp source, RewriterBase &rewriter) {
1223+
OpBuilder::InsertionGuard guard(rewriter);
12231224
Block *block1 = target.getBody();
12241225
Block *block2 = source.getBody();
12251226
auto term1 = cast<scf::ReduceOp>(block1->getTerminator());

0 commit comments

Comments
 (0)