[OpenMP 60] Initial parsing/sema for need_device_addr modifier on adjust_args clause

Adds initial parsing and semantic analysis for `need_device_addr`
modifier on `adjust_args` clause.

PR Link: #143442

Author: mdfazlay

clang/include/clang/Basic/DiagnosticParseKinds.td

@@ -1582,8 +1582,9 @@ def err_omp_unexpected_append_op : Error<
 def err_omp_unexpected_execution_modifier : Error<
   "unexpected 'execution' modifier in non-executable context">;
 def err_omp_unknown_adjust_args_op
-    : Error<"incorrect adjust_args type, expected 'need_device_ptr'%select{|, "
-            "'need_device_addr',}0 or 'nothing'">;
+    : Error<
+          "incorrect 'adjust_args' type, expected 'need_device_ptr'%select{|, "
+          "'need_device_addr',}0 or 'nothing'">;
 def err_omp_declare_variant_wrong_clause : Error<
   "expected %select{'match'|'match', 'adjust_args', or 'append_args'}0 clause "
   "on 'omp declare variant' directive">;

clang/lib/Parse/ParseOpenMP.cpp

@@ -1517,12 +1517,19 @@ void Parser::ParseOMPDeclareVariantClauses(Parser::DeclGroupPtrTy Ptr,
         IsError = ParseOpenMPVarList(OMPD_declare_variant, OMPC_adjust_args,
                                      Vars, Data);
         if (!IsError) {
-          if (Data.ExtraModifier == OMPC_ADJUST_ARGS_nothing)
+          switch (Data.ExtraModifier) {
+          case OMPC_ADJUST_ARGS_nothing:
             llvm::append_range(AdjustNothing, Vars);
-          else if (Data.ExtraModifier == OMPC_ADJUST_ARGS_need_device_ptr)
+            break;
+          case OMPC_ADJUST_ARGS_need_device_ptr:
             llvm::append_range(AdjustNeedDevicePtr, Vars);
-          else if (Data.ExtraModifier == OMPC_ADJUST_ARGS_need_device_addr)
+            break;
+          case OMPC_ADJUST_ARGS_need_device_addr:
             llvm::append_range(AdjustNeedDeviceAddr, Vars);
+            break;
+          default:
+            break;
+          }
         }
         break;
       }

clang/test/OpenMP/declare_variant_clauses_messages.cpp

@@ -196,12 +196,12 @@ void vararg_bar2(const char *fmt) { return; }
 // expected-error@+1 {{variant in '#pragma omp declare variant' with type 'void (float *, float *, int *, omp_interop_t)' (aka 'void (float *, float *, int *, void *)') is incompatible with type 'void (float *, float *, int *)'}}
 #pragma omp declare variant(foo_v4) match(construct={dispatch})
 
-// expected-error@+3 {{incorrect adjust_args type, expected 'need_device_ptr', 'need_device_addr', or 'nothing'}}
+// expected-error@+3 {{incorrect 'adjust_args' type, expected 'need_device_ptr', 'need_device_addr', or 'nothing'}}
 #pragma omp declare variant(foo_v1)                        \
    match(construct={dispatch}, device={arch(arm)})         \
    adjust_args(badaaop:AAA,BBB)
 
-// expected-error@+3 {{incorrect adjust_args type, expected 'need_device_ptr', 'need_device_addr', or 'nothing'}}
+// expected-error@+3 {{incorrect 'adjust_args' type, expected 'need_device_ptr', 'need_device_addr', or 'nothing'}}
 #pragma omp declare variant(foo_v1)                        \
    match(construct={dispatch}, device={arch(arm)})         \
    adjust_args(badaaop AAA,BBB)