Skip to content

Commit c73941f

Browse files
committed
Address more user feedback.
1 parent b47221b commit c73941f

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1516,7 +1516,8 @@ DWARFVerifier::verifyNameIndexAbbrevs(const DWARFDebugNames::NameIndex &NI) {
15161516
!Attributes.count(dwarf::DW_IDX_type_unit)) {
15171517
ErrorCategory.Report("Abbreviation contains no attribute", [&]() {
15181518
error() << formatv("NameIndex @ {0:x}: Indexing multiple compile units "
1519-
"and abbreviation {1:x} has no {2} attribute.\n",
1519+
"and abbreviation {1:x} has no DW_IDX_compile_unit "
1520+
"or DW_IDX_type_unit attribute.\n",
15201521
NI.getUnitOffset(), Abbrev.Code,
15211522
dwarf::DW_IDX_compile_unit);
15221523
});

llvm/test/tools/llvm-dwarfdump/X86/debug-names-verify-abbrev-forms.s

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
# CHECK: NameIndex @ 0x0: Abbreviation 0x1: DW_IDX_die_offset uses an unknown form: DW_FORM_unknown_1fff.
1010
# CHECK: warning: NameIndex @ 0x0: Abbreviation 0x3 references an unknown tag: DW_TAG_unknown_8080.
1111
# CHECK: error: NameIndex @ 0x0: Abbreviation 0x5 has no DW_IDX_die_offset attribute.
12-
# CHECK: error: NameIndex @ 0x55: Indexing multiple compile units and abbreviation 0x1 has no DW_IDX_compile_unit attribute.
12+
# CHECK: error: NameIndex @ 0x55: Indexing multiple compile units and abbreviation 0x1 has no DW_IDX_compile_unit or DW_IDX_type_unit attribute.
1313

1414
.section .debug_str,"MS",@progbits,1
1515
.Lstring_producer:

0 commit comments

Comments
 (0)