Override TraversePseudoObjectExpr

Author: zyn0217

clang-tools-extra/clangd/InlayHints.cpp

@@ -589,17 +589,22 @@ class InlayHintVisitor : public RecursiveASTVisitor<InlayHintVisitor> {
     return true;
   }
 
-  bool dataTraverseStmtPre(Stmt *S) {
-    // Do not show inlay hints for the __builtin_dump_struct, which would expand
-    // to a PseudoObjectExpr that includes a couple of calls to a printf
-    // function. Printing parameter names for that anyway would end up with
-    // duplicate parameter names (which, however, got de-duplicated after
+  bool TraversePseudoObjectExpr(PseudoObjectExpr *E) {
+    // Do not show inlay hints for the __builtin_dump_struct, which would
+    // expand to a PseudoObjectExpr that includes a couple of calls to a
+    // printf function. Printing parameter names for that anyway would end up
+    // with duplicate parameter names (which, however, got de-duplicated after
     // visiting) for the printf function.
-    if (auto *POE = dyn_cast<PseudoObjectExpr>(S))
-      if (auto *CE = dyn_cast<CallExpr>(POE->getSyntacticForm());
-          CE && CE->getBuiltinCallee() == Builtin::BI__builtin_dump_struct)
-        return false;
-    return true;
+    if (auto *CE = dyn_cast<CallExpr>(E->getSyntacticForm());
+        CE && CE->getBuiltinCallee() == Builtin::BI__builtin_dump_struct)
+      // Only traverse the syntactic forms. This leaves the door open in case
+      // the arguments in the syntactic form for __builtin_dump_struct could
+      // possibly get parameter names.
+      return RecursiveASTVisitor<InlayHintVisitor>::TraverseStmt(
+          E->getSyntacticForm());
+    // FIXME: Shall we ignore semantic forms for other pseudo object
+    // expressions?
+    return RecursiveASTVisitor<InlayHintVisitor>::TraversePseudoObjectExpr(E);
   }
 
   bool VisitCallExpr(CallExpr *E) {