More precise explanation for test_vfscanf

alejandro-alvarez-sonarsource · steakhal · commit c8c9bd3a1bcf · 2024-02-28T12:22:22.000+01:00
diff --git a/clang/test/Analysis/stream-invalidate.c b/clang/test/Analysis/stream-invalidate.c
@@ -179,9 +179,11 @@ int test_vfscanf_inner(const char *fmt, ...) {
 
 void test_vfscanf() {
   int i = 42;
+  int j = 43;
   int r = test_vfscanf_inner("%d", &i);
   if (r != EOF) {
+    // i gets invalidated by the call to test_vfscanf_inner, not by vfscanf.
     clang_analyzer_dump(i); // expected-warning {{conj_$}}
-    // FIXME va_list "hides" the pointer to i
+    clang_analyzer_dump(j); // expected-warning {{43 S32b}}
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -179,9 +179,11 @@ int test_vfscanf_inner(const char *fmt, ...) {`
`179`	`179`
`180`	`180`	`void test_vfscanf() {`
`181`	`181`	`int i = 42;`
	`182`	`+ int j = 43;`
`182`	`183`	`int r = test_vfscanf_inner("%d", &i);`
`183`	`184`	`if (r != EOF) {`
	`185`	`+ // i gets invalidated by the call to test_vfscanf_inner, not by vfscanf.`
`184`	`186`	`clang_analyzer_dump(i); // expected-warning {{conj_$}}`
`185`		`- // FIXME va_list "hides" the pointer to i`
	`187`	`+ clang_analyzer_dump(j); // expected-warning {{43 S32b}}`
`186`	`188`	`}`
`187`	`189`	`}`