Skip to content

Commit c8df891

Browse files
committed
[NFC] Disambiguate llvm::Module references
Add an llvm namespace to Module references to disambiguate it from clang::Module. This is needed to include new header files that expose clang::Module
1 parent 0de3e4a commit c8df891

File tree

1 file changed

+22
-21
lines changed

1 file changed

+22
-21
lines changed

clang/lib/CodeGen/BackendUtil.cpp

Lines changed: 22 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ class EmitAssemblyHelper {
113113
const CodeGenOptions &CodeGenOpts;
114114
const clang::TargetOptions &TargetOpts;
115115
const LangOptions &LangOpts;
116-
Module *TheModule;
116+
llvm::Module *TheModule;
117117
IntrusiveRefCntPtr<llvm::vfs::FileSystem> VFS;
118118

119119
Timer CodeGenerationTime;
@@ -179,7 +179,7 @@ class EmitAssemblyHelper {
179179
const HeaderSearchOptions &HeaderSearchOpts,
180180
const CodeGenOptions &CGOpts,
181181
const clang::TargetOptions &TOpts,
182-
const LangOptions &LOpts, Module *M,
182+
const LangOptions &LOpts, llvm::Module *M,
183183
IntrusiveRefCntPtr<llvm::vfs::FileSystem> VFS)
184184
: Diags(_Diags), HSOpts(HeaderSearchOpts), CodeGenOpts(CGOpts),
185185
TargetOpts(TOpts), LangOpts(LOpts), TheModule(M), VFS(std::move(VFS)),
@@ -693,7 +693,7 @@ static void addSanitizers(const Triple &TargetTriple,
693693
// the logic of the original code, but operates on "shadow" values. It
694694
// can benefit from re-running some general purpose optimization
695695
// passes.
696-
MPM.addPass(RequireAnalysisPass<GlobalsAA, Module>());
696+
MPM.addPass(RequireAnalysisPass<GlobalsAA, llvm::Module>());
697697
FunctionPassManager FPM;
698698
FPM.addPass(EarlyCSEPass(true /* Enable mem-ssa. */));
699699
FPM.addPass(InstCombinePass());
@@ -752,7 +752,7 @@ static void addSanitizers(const Triple &TargetTriple,
752752
SanitizersCallback(NewMPM, Level);
753753
if (!NewMPM.isEmpty()) {
754754
// Sanitizers can abandon<GlobalsAA>.
755-
NewMPM.addPass(RequireAnalysisPass<GlobalsAA, Module>());
755+
NewMPM.addPass(RequireAnalysisPass<GlobalsAA, llvm::Module>());
756756
MPM.addPass(std::move(NewMPM));
757757
}
758758
});
@@ -1051,7 +1051,7 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
10511051
if (Action == Backend_EmitBC || Action == Backend_EmitLL) {
10521052
if (CodeGenOpts.PrepareForThinLTO && !CodeGenOpts.DisableLLVMPasses) {
10531053
if (!TheModule->getModuleFlag("EnableSplitLTOUnit"))
1054-
TheModule->addModuleFlag(Module::Error, "EnableSplitLTOUnit",
1054+
TheModule->addModuleFlag(llvm::Module::Error, "EnableSplitLTOUnit",
10551055
CodeGenOpts.EnableSplitLTOUnit);
10561056
if (Action == Backend_EmitBC) {
10571057
if (!CodeGenOpts.ThinLinkBitcodeFile.empty()) {
@@ -1060,7 +1060,7 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
10601060
return;
10611061
}
10621062
if (CodeGenOpts.UnifiedLTO)
1063-
TheModule->addModuleFlag(Module::Error, "UnifiedLTO", uint32_t(1));
1063+
TheModule->addModuleFlag(llvm::Module::Error, "UnifiedLTO", uint32_t(1));
10641064
MPM.addPass(ThinLTOBitcodeWriterPass(
10651065
*OS, ThinLinkOS ? &ThinLinkOS->os() : nullptr));
10661066
} else {
@@ -1074,12 +1074,12 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
10741074
bool EmitLTOSummary = shouldEmitRegularLTOSummary();
10751075
if (EmitLTOSummary) {
10761076
if (!TheModule->getModuleFlag("ThinLTO") && !CodeGenOpts.UnifiedLTO)
1077-
TheModule->addModuleFlag(Module::Error, "ThinLTO", uint32_t(0));
1077+
TheModule->addModuleFlag(llvm::Module::Error, "ThinLTO", uint32_t(0));
10781078
if (!TheModule->getModuleFlag("EnableSplitLTOUnit"))
1079-
TheModule->addModuleFlag(Module::Error, "EnableSplitLTOUnit",
1079+
TheModule->addModuleFlag(llvm::Module::Error, "EnableSplitLTOUnit",
10801080
uint32_t(1));
10811081
if (CodeGenOpts.UnifiedLTO)
1082-
TheModule->addModuleFlag(Module::Error, "UnifiedLTO", uint32_t(1));
1082+
TheModule->addModuleFlag(llvm::Module::Error, "UnifiedLTO", uint32_t(1));
10831083
}
10841084
if (Action == Backend_EmitBC)
10851085
MPM.addPass(BitcodeWriterPass(*OS, CodeGenOpts.EmitLLVMUseLists,
@@ -1093,13 +1093,13 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
10931093
// Set module flags, like EnableSplitLTOUnit and UnifiedLTO, since FatLTO
10941094
// uses a different action than Backend_EmitBC or Backend_EmitLL.
10951095
if (!TheModule->getModuleFlag("ThinLTO"))
1096-
TheModule->addModuleFlag(Module::Error, "ThinLTO",
1096+
TheModule->addModuleFlag(llvm::Module::Error, "ThinLTO",
10971097
uint32_t(CodeGenOpts.PrepareForThinLTO));
10981098
if (!TheModule->getModuleFlag("EnableSplitLTOUnit"))
1099-
TheModule->addModuleFlag(Module::Error, "EnableSplitLTOUnit",
1099+
TheModule->addModuleFlag(llvm::Module::Error, "EnableSplitLTOUnit",
11001100
uint32_t(CodeGenOpts.EnableSplitLTOUnit));
11011101
if (CodeGenOpts.UnifiedLTO && !TheModule->getModuleFlag("UnifiedLTO"))
1102-
TheModule->addModuleFlag(Module::Error, "UnifiedLTO", uint32_t(1));
1102+
TheModule->addModuleFlag(llvm::Module::Error, "UnifiedLTO", uint32_t(1));
11031103
}
11041104

11051105
// Print a textual, '-passes=' compatible, representation of pipeline if
@@ -1195,11 +1195,12 @@ void EmitAssemblyHelper::EmitAssembly(BackendAction Action,
11951195
}
11961196

11971197
static void runThinLTOBackend(
1198-
DiagnosticsEngine &Diags, ModuleSummaryIndex *CombinedIndex, Module *M,
1199-
const HeaderSearchOptions &HeaderOpts, const CodeGenOptions &CGOpts,
1200-
const clang::TargetOptions &TOpts, const LangOptions &LOpts,
1201-
std::unique_ptr<raw_pwrite_stream> OS, std::string SampleProfile,
1202-
std::string ProfileRemapping, BackendAction Action) {
1198+
DiagnosticsEngine &Diags, ModuleSummaryIndex *CombinedIndex,
1199+
llvm::Module *M, const HeaderSearchOptions &HeaderOpts,
1200+
const CodeGenOptions &CGOpts, const clang::TargetOptions &TOpts,
1201+
const LangOptions &LOpts, std::unique_ptr<raw_pwrite_stream> OS,
1202+
std::string SampleProfile, std::string ProfileRemapping,
1203+
BackendAction Action) {
12031204
DenseMap<StringRef, DenseMap<GlobalValue::GUID, GlobalValueSummary *>>
12041205
ModuleToDefinedGVSummaries;
12051206
CombinedIndex->collectDefinedGVSummariesPerModule(ModuleToDefinedGVSummaries);
@@ -1268,18 +1269,18 @@ static void runThinLTOBackend(
12681269
Conf.SplitDwarfOutput = CGOpts.SplitDwarfOutput;
12691270
switch (Action) {
12701271
case Backend_EmitNothing:
1271-
Conf.PreCodeGenModuleHook = [](size_t Task, const Module &Mod) {
1272+
Conf.PreCodeGenModuleHook = [](size_t Task, const llvm::Module &Mod) {
12721273
return false;
12731274
};
12741275
break;
12751276
case Backend_EmitLL:
1276-
Conf.PreCodeGenModuleHook = [&](size_t Task, const Module &Mod) {
1277+
Conf.PreCodeGenModuleHook = [&](size_t Task, const llvm::Module &Mod) {
12771278
M->print(*OS, nullptr, CGOpts.EmitLLVMUseLists);
12781279
return false;
12791280
};
12801281
break;
12811282
case Backend_EmitBC:
1282-
Conf.PreCodeGenModuleHook = [&](size_t Task, const Module &Mod) {
1283+
Conf.PreCodeGenModuleHook = [&](size_t Task, const llvm::Module &Mod) {
12831284
WriteBitcodeToFile(*M, *OS, CGOpts.EmitLLVMUseLists);
12841285
return false;
12851286
};
@@ -1303,7 +1304,7 @@ void clang::EmitBackendOutput(DiagnosticsEngine &Diags,
13031304
const CodeGenOptions &CGOpts,
13041305
const clang::TargetOptions &TOpts,
13051306
const LangOptions &LOpts, StringRef TDesc,
1306-
Module *M, BackendAction Action,
1307+
llvm::Module *M, BackendAction Action,
13071308
IntrusiveRefCntPtr<llvm::vfs::FileSystem> VFS,
13081309
std::unique_ptr<raw_pwrite_stream> OS) {
13091310

0 commit comments

Comments
 (0)