[scudo] Add ALWAYS_INLINE to ScopedTSD ctor (#81982)

fabio-d · web-flow · commit cc673867d97a · 2024-02-16T19:48:07.000+01:00
Fix for performance regression introduced by #80061 that slowed down Fuchsia's MallocFree microbenchmark by 3.5 - 8%
diff --git a/compiler-rt/lib/scudo/standalone/tsd_exclusive.h b/compiler-rt/lib/scudo/standalone/tsd_exclusive.h
@@ -30,7 +30,7 @@ template <class Allocator> struct TSDRegistryExT {
   using ThisT = TSDRegistryExT<Allocator>;
 
   struct ScopedTSD {
-    ScopedTSD(ThisT &TSDRegistry) {
+    ALWAYS_INLINE ScopedTSD(ThisT &TSDRegistry) {
       CurrentTSD = TSDRegistry.getTSDAndLock(&UnlockRequired);
       DCHECK_NE(CurrentTSD, nullptr);
     }
diff --git a/compiler-rt/lib/scudo/standalone/tsd_shared.h b/compiler-rt/lib/scudo/standalone/tsd_shared.h
@@ -29,7 +29,7 @@ struct TSDRegistrySharedT {
   using ThisT = TSDRegistrySharedT<Allocator, TSDsArraySize, DefaultTSDCount>;
 
   struct ScopedTSD {
-    ScopedTSD(ThisT &TSDRegistry) {
+    ALWAYS_INLINE ScopedTSD(ThisT &TSDRegistry) {
       CurrentTSD = TSDRegistry.getTSDAndLock();
       DCHECK_NE(CurrentTSD, nullptr);
     }

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ template <class Allocator> struct TSDRegistryExT {`
`30`	`30`	`using ThisT = TSDRegistryExT<Allocator>;`
`31`	`31`
`32`	`32`	`struct ScopedTSD {`
`33`		`- ScopedTSD(ThisT &TSDRegistry) {`
	`33`	`+ ALWAYS_INLINE ScopedTSD(ThisT &TSDRegistry) {`
`34`	`34`	`CurrentTSD = TSDRegistry.getTSDAndLock(&UnlockRequired);`
`35`	`35`	`DCHECK_NE(CurrentTSD, nullptr);`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ struct TSDRegistrySharedT {`
`29`	`29`	`using ThisT = TSDRegistrySharedT<Allocator, TSDsArraySize, DefaultTSDCount>;`
`30`	`30`
`31`	`31`	`struct ScopedTSD {`
`32`		`- ScopedTSD(ThisT &TSDRegistry) {`
	`32`	`+ ALWAYS_INLINE ScopedTSD(ThisT &TSDRegistry) {`
`33`	`33`	`CurrentTSD = TSDRegistry.getTSDAndLock();`
`34`	`34`	`DCHECK_NE(CurrentTSD, nullptr);`
`35`	`35`	`}`