Avoid selecting e32 case on gfx12; not sure how to best check for requiring the op_sel form

arsenm · arsenm · commit cc9a3b9e7544 · 2024-10-01T18:54:54.000+04:00
diff --git a/llvm/lib/Target/AMDGPU/VOP1Instructions.td b/llvm/lib/Target/AMDGPU/VOP1Instructions.td
@@ -590,7 +590,7 @@ let OtherPredicates = [HasCvtFP8VOP1Bug] in {
                (V_CVT_F32_BF8_sdwa 0, $src, 0, 0, 0)>;
 }
 
-let OtherPredicates = [HasNoCvtFP8VOP1Bug] in {
+let OtherPredicates = [HasNoCvtFP8VOP1Bug, HasSDWA] in { // FIXME: HasSDWA is a substitute for !gfx12
   def : GCNPat<(f32 (int_amdgcn_cvt_f32_fp8 i32:$src, 0)),
                (V_CVT_F32_FP8_e32 $src)>;
   def : GCNPat<(f32 (int_amdgcn_cvt_f32_bf8 i32:$src, 0)),

Original file line number	Diff line number	Diff line change
`@@ -590,7 +590,7 @@ let OtherPredicates = [HasCvtFP8VOP1Bug] in {`
`590`	`590`	`(V_CVT_F32_BF8_sdwa 0, $src, 0, 0, 0)>;`
`591`	`591`	`}`
`592`	`592`
`593`		`-let OtherPredicates = [HasNoCvtFP8VOP1Bug] in {`
	`593`	`+let OtherPredicates = [HasNoCvtFP8VOP1Bug, HasSDWA] in { // FIXME: HasSDWA is a substitute for !gfx12`
`594`	`594`	`def : GCNPat<(f32 (int_amdgcn_cvt_f32_fp8 i32:$src, 0)),`
`595`	`595`	`(V_CVT_F32_FP8_e32 $src)>;`
`596`	`596`	`def : GCNPat<(f32 (int_amdgcn_cvt_f32_bf8 i32:$src, 0)),`