Skip to content

Commit cd24120

Browse files
committed
[clang] Remove a FIXME that we can't fix
I added this recently, but it looks like several tests very intentionally check that `-mios-version-min=foo --target=x86_64-apple-ios` does simulator builds. So we can't easily remove this hack, even though it makes little sense in an arm mac world. (Here, you _have_ to say `-mios-simulator-version-min=` or `--target=arm64-apple-ios-simulator`.) The tests that check this: Clang :: Driver/darwin-ld.c Clang :: Driver/darwin-simulator-macro.c Clang :: Driver/darwin-version.c No behavior change. Differential Revision: https://reviews.llvm.org/D132400
1 parent 0af3ab0 commit cd24120

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

clang/lib/Driver/ToolChains/Darwin.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2241,7 +2241,6 @@ void Darwin::AddDeploymentTarget(DerivedArgList &Args) const {
22412241

22422242
DarwinEnvironmentKind Environment = OSTarget->getEnvironment();
22432243
// Recognize iOS targets with an x86 architecture as the iOS simulator.
2244-
// FIXME: Remove this.
22452244
if (Environment == NativeEnvironment && Platform != MacOS &&
22462245
Platform != DriverKit && OSTarget->canInferSimulatorFromArch() &&
22472246
getTriple().isX86())

0 commit comments

Comments
 (0)