Skip to content

Commit ce4c93f

Browse files
committed
[libc] Fix test includes
1 parent 02031fb commit ce4c93f

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

libc/test/src/sys/time/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ add_libc_unittest(
3131
libc.src.__support.common
3232
libc.src.errno.errno
3333
libc.test.UnitTest.ErrnoSetterMatcher
34+
libc.include.signal
3435
)
3536

3637
add_libc_unittest(

libc/test/src/sys/time/getitimer_test.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,11 @@
77
//
88
//===----------------------------------------------------------------------===//
99

10-
#include "src/sys/time/getitimer.h"
1110
#include "hdr/types/struct_itimerval.h"
11+
#include "src/sys/time/getitimer.h"
1212
#include "test/UnitTest/ErrnoSetterMatcher.h"
1313
#include "test/UnitTest/Test.h"
14+
#include <sys/time.h>
1415

1516
using namespace LIBC_NAMESPACE::testing::ErrnoSetterMatcher;
1617

@@ -21,7 +22,7 @@ TEST(LlvmLibcSysTimeGetitimerTest, SmokeTest) {
2122
timer.it_interval.tv_sec = -1;
2223
timer.it_interval.tv_usec = -1;
2324

24-
ASSERT_THAT(LIBC_NAMESPACE::getitimer(ITIMER_REAL, &timer),
25+
ASSERT_THAT(LIBC_NAMESPACE::getitimer(0, &timer),
2526
returns(EQ(0)).with_errno(EQ(0)));
2627

2728
ASSERT_TRUE(timer.it_value.tv_sec == 0);

libc/test/src/sys/time/setitimer_test.cpp

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,23 +7,21 @@
77
//
88
//===----------------------------------------------------------------------===//
99

10-
#include "src/signal/signal.h"
1110
#include "hdr/types/struct_itimerval.h"
1211
#include "src/sys/time/setitimer.h"
1312
#include "test/UnitTest/ErrnoSetterMatcher.h"
1413
#include "test/UnitTest/Test.h"
1514

16-
#include <atomic>
1715
#include <signal.h>
1816

1917
using namespace LIBC_NAMESPACE::testing::ErrnoSetterMatcher;
2018

21-
static std::atomic<bool> timer_fired(false);
19+
static bool timer_fired(false);
2220

23-
extern "C" void handle_sigalrm(int) { timer_fired.store(true); }
21+
extern "C" void handle_sigalrm(int) { timer_fired = true; }
2422

2523
TEST(LlvmLibcSysTimeSetitimerTest, SmokeTest) {
26-
errno = 0;
24+
LIBC_NAMESPACE::libc_errno = 0;
2725
struct sigaction sa;
2826
sa.sa_handler = handle_sigalrm;
2927
sigemptyset(&sa.sa_mask);
@@ -36,13 +34,13 @@ TEST(LlvmLibcSysTimeSetitimerTest, SmokeTest) {
3634
timer.it_interval.tv_sec = 0;
3735
timer.it_interval.tv_usec = 0; // One-shot timer
3836

39-
ASSERT_THAT(LIBC_NAMESPACE::setitimer(ITIMER_REAL, &timer, nullptr),
37+
ASSERT_THAT(LIBC_NAMESPACE::setitimer(0, &timer, nullptr),
4038
returns(EQ(0)).with_errno(EQ(0)));
4139

4240
while (true) {
43-
if (timer_fired.load())
41+
if (timer_fired)
4442
break;
4543
}
4644

47-
ASSERT_TRUE(timer_fired.load());
45+
ASSERT_TRUE(timer_fired);
4846
}

0 commit comments

Comments
 (0)